commit 7fef173c28f7462dcd8ee017fdf12b5073f54c02
author djm@openbsd.org <djm@openbsd.org> Thu Aug 23 03:01:08 2018 +0000
committer Damien Miller <djm@mindrot.org> Thu Aug 23 13:02:21 2018 +1000
tree 69b7561b47f5452067248424a6ef3e7957cac43e
parent b8ae02a2896778b8984c7f51566c7f0f56fa8b56

upstream: memleak introduced in r1.83; from Colin Watson

OpenBSD-Commit-ID: 5c019104c280cbd549a264a7217b67665e5732dc

auth2-pubkey.c

diff --git a/auth2-pubkey.c b/auth2-pubkey.c
index e1c1504..3d9f9af 100644
--- a/auth2-pubkey.c
+++ b/auth2-pubkey.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2-pubkey.c,v 1.83 2018/07/31 03:10:27 djm Exp $ */
+/* $OpenBSD: auth2-pubkey.c,v 1.84 2018/08/23 03:01:08 djm Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -193,7 +193,6 @@
 		    ssh->compat)) == 0) {
 			authenticated = 1;
 		}
-		sshbuf_free(b);
 		auth2_record_key(authctxt, authenticated, key);
 	} else {
 		debug("%s: test pkalg %s pkblob %s%s%s",
@@ -235,6 +234,7 @@
 	}
 	debug2("%s: authenticated %d pkalg %s", __func__, authenticated, pkalg);
 
+	sshbuf_free(b);
 	sshauthopt_free(authopts);
 	sshkey_free(key);
 	free(userstyle);