commit f7dadaaf75634289f7ead64ed1802b627d761ee3
author Quipyowert2 <38995150+Quipyowert2@users.noreply.github.com> Wed Feb 13 11:00:31 2019 -0800
committer Ralph Giles <giles@thaumas.net> Mon Mar 18 17:58:58 2019 -0700
tree 033d0d8f3e071f15955ce63d05c2f2f602d48872
parent 6f5e79a95a97e5d144f4e127e7f479e4bc3463cf

Use %lu instead of %ld to fprintf unsigned longs.

Fixes a cppcheck warning. Possibly we should just convert
the array type to `long` since that's what oggpack_look()
returns, using negative values to report error.

However, none of the compared values are out of range
for either type so it doesn't really matter.

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Signed-off-by: Ralph Giles <giles@thaumas.net>

src/bitwise.c

diff --git a/src/bitwise.c b/src/bitwise.c
index 81865ef..f5ef791 100644
--- a/src/bitwise.c
+++ b/src/bitwise.c
@@ -889,7 +889,7 @@
   for(i=0;i<test2size;i++){
     if(oggpack_look(&r,32)==-1)report("out of data. failed!");
     if(oggpack_look(&r,32)!=large[i]){
-      fprintf(stderr,"%ld != %ld (%lx!=%lx):",oggpack_look(&r,32),large[i],
+      fprintf(stderr,"%ld != %lu (%lx!=%lx):",oggpack_look(&r,32),large[i],
               oggpack_look(&r,32),large[i]);
       report("read incorrect value!\n");
     }
@@ -999,7 +999,7 @@
   for(i=0;i<test2size;i++){
     if(oggpackB_look(&r,32)==-1)report("out of data. failed!");
     if(oggpackB_look(&r,32)!=large[i]){
-      fprintf(stderr,"%ld != %ld (%lx!=%lx):",oggpackB_look(&r,32),large[i],
+      fprintf(stderr,"%ld != %lu (%lx!=%lx):",oggpackB_look(&r,32),large[i],
               oggpackB_look(&r,32),large[i]);
       report("read incorrect value!\n");
     }