Merge pull request #1790 from neheb/bool
[clang-tidy] simplify boolean expression
diff --git a/.clang-tidy b/.clang-tidy
index 18ffaac..e0afd47 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -5,6 +5,7 @@
,readability-non-const-parameter,
,readability-redundant-string-cstr,
,readability-redundant-string-init,
+ ,readability-simplify-boolean-expr,
'
WarningsAsErrors: '
,readability-avoid-const-params-in-decls,
@@ -12,4 +13,5 @@
,readability-non-const-parameter,
,readability-redundant-string-cstr,
,readability-redundant-string-init,
+ ,readability-simplify-boolean-expr,
'
diff --git a/src/manifest_parser.cc b/src/manifest_parser.cc
index 860a8fc..54ad3f4 100644
--- a/src/manifest_parser.cc
+++ b/src/manifest_parser.cc
@@ -202,10 +202,7 @@
return false;
} while (!eval.empty());
- if (!ExpectToken(Lexer::NEWLINE, err))
- return false;
-
- return true;
+ return ExpectToken(Lexer::NEWLINE, err);
}
bool ManifestParser::ParseEdge(string* err) {
