commit f4a2915a7adacfad36cb2aedfcfab3cc0fde0918
author Xie Shi <xieshi@douban.com> Thu Mar 21 12:08:49 2013 +0800
committer Xie Shi <xieshi@douban.com> Thu Mar 21 12:08:49 2013 +0800
tree a11d10fef253f903f720c8f118d422505d5e58cd
parent 779e1f330ee112500f862d5fdf056654abd48d37

legacy_html_escape use string replace, which is faster than regex

mako/filters.py

diff --git a/mako/filters.py b/mako/filters.py
index 428c926..b1ce924 100644
--- a/mako/filters.py
+++ b/mako/filters.py
@@ -24,12 +24,15 @@
 # XXX: " is valid in HTML and XML
 #      ' is not valid HTML, but is valid XML
 
-LEGACY_HTML_ESCAPE_RE = re.compile(r'([&<"\'>])')
-
-def legacy_html_escape(string):
+def legacy_html_escape(s):
     """legacy HTML escape for non-unicode mode."""
-
-    return LEGACY_HTML_ESCAPE_RE.sub(lambda m: xml_escapes[m.group()], string)
+    s = s.replace("&", "&amp;") 
+    s = s.replace(">", "&gt;")  
+    s = s.replace("<", "&lt;")  
+    s = s.replace('"', "&#34;")
+    s = s.replace("'", "&#39;")
+    return s
+ 
 
 try:
     import markupsafe