commit 7cf57380b11d20b0bd4c86a493db7a0e1d0f0071
author Daniel Veillard <veillard@redhat.com> Wed Oct 08 16:09:56 2014 +0800
committer Daniel Veillard <veillard@redhat.com> Wed Oct 08 16:09:56 2014 +0800
tree 22a3212f9f999bdf7546a36c16b61d2e29fe0c64
parent 7dc24965092d7cc310908d6052913050e88ec072

Parser error on repeated recursive entity expansion containing <

For https://bugzilla.gnome.org/show_bug.cgi?id=736417

basically a weird side effect and a failure
to properly parenthesize a boolean expression led to this bug

parser.c

diff --git a/parser.c b/parser.c
index 2ef2c3b..b9a37ab 100644
--- a/parser.c
+++ b/parser.c
@@ -7684,8 +7684,8 @@
     else if ((ctxt->instate == XML_PARSER_ATTRIBUTE_VALUE) &&
 	     (ent != NULL) && 
 	     (ent->etype != XML_INTERNAL_PREDEFINED_ENTITY)) {
-	if ((ent->checked & 1) || ((ent->checked == 0) &&
-	     (ent->content != NULL) &&(xmlStrchr(ent->content, '<')))) {
+	if (((ent->checked & 1) || (ent->checked == 0)) &&
+	     (ent->content != NULL) && (xmlStrchr(ent->content, '<'))) {
 	    xmlFatalErrMsgStr(ctxt, XML_ERR_LT_IN_ATTRIBUTE,
 	"'<' in entity '%s' is not allowed in attributes values\n", name);
         }