commit ca5222ea819cc5ed797860070b4c6c1aeeb28420
author Daniel Stenberg <daniel@haxx.se> Thu Feb 11 13:52:20 2016 +0100
committer Daniel Stenberg <daniel@haxx.se> Tue Feb 23 08:23:19 2016 +0100
tree de3e291a53ff7f5b6f75764ada586a027a04257f
parent d453f4ce3c87c4dbe1f86be4913d0018bb602b42

diffie_hellman_sha256: convert bytes to bits

As otherwise we get far too small numbers.

Reported-by: Andreas Schneider

CVE-2016-0787

src/kex.c

diff --git a/src/kex.c b/src/kex.c
index 6349457..e89b36c 100644
--- a/src/kex.c
+++ b/src/kex.c
@@ -753,7 +753,7 @@
         memset(&exchange_state->req_state, 0, sizeof(packet_require_state_t));
 
         /* Generate x and e */
-        _libssh2_bn_rand(exchange_state->x, group_order, 0, -1);
+        _libssh2_bn_rand(exchange_state->x, group_order * 8 - 1, 0, -1);
         _libssh2_bn_mod_exp(exchange_state->e, g, exchange_state->x, p,
                             exchange_state->ctx);