commit a7a4ec7f9c088c972d6e7b91ee422d569dc44c92
author Bruce A. Mah <bmah@kitchenlab.org> Thu May 04 14:16:42 2017 -0700
committer Bruce A. Mah <bmah@es.net> Thu May 04 14:33:53 2017 -0700
tree a9b4693e9eba0b29f54078881c5676f9a7530ea7
parent 30d8c2828a07931f64d5b79607779a5dacadc597

Fix a heap corruption issue leading to a server-side crash. (#564)

Commit 5ab2132c (PR #551) fixed, among other things, a memory
leak.  The solution, however, causes a hazard where a free() of
an invalid pointer can corrupt the heap.  We've observed this
fairly repeatably while running the test_commands.sh script on
CentOS 7.

To remedy this, we NULL out a pointer after the object it
pointed to has been free-d, just like a number of other similar
objects.

(cherry picked from commit 103d4318e85783b99d6984c091ea878fc0d844b2)

src/iperf_server_api.c

diff --git a/src/iperf_server_api.c b/src/iperf_server_api.c
index 79ae695..9a01b54 100644
--- a/src/iperf_server_api.c
+++ b/src/iperf_server_api.c
@@ -466,6 +466,7 @@
     }
     if (test->congestion_used != NULL) {
         free(test->congestion_used);
+	test->congestion_used = NULL;
     }
     if (test->timer != NULL) {
         tmr_cancel(test->timer);