commit 461cc443dd51d78298539074c5e4455d96287466
author Tamir Duberstein <tamird@google.com> Sun May 09 11:48:48 2021 -0400
committer Tamir Duberstein <tamird@google.com> Sun May 09 19:21:46 2021 +0000
tree 4240dc45a4d66cc5546ec8c71b1c4df30c77daf0
parent 433ae96599636858185f35582a3863b15fc47f1d

[config] Suppress implicit fallthrough

Change-Id: If747e186131dad30750f1b6a41b68dfdb281fed9
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/grpc/+/527273
Reviewed-by: Shai Barack <shayba@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index f3a4444..929ac3d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -22,10 +22,11 @@
 
 config("grpc_warnings") {
   cflags = [
-    "-Wno-implicit-int-float-conversion",
-    "-Wno-unused-variable",
-    "-Wno-string-concatenation",
     "-Wno-conversion",
+    "-Wno-implicit-fallthrough",
+    "-Wno-implicit-int-float-conversion",
+    "-Wno-string-concatenation",
+    "-Wno-unused-variable",
   ]
 }
 
@@ -136,6 +137,7 @@
     "src/core/lib/support/wrap_memcpy.cc",
   ]
 
+  configs += [ ":grpc_warnings" ]
   public_configs = [ ":grpc_config" ]
 }
 
@@ -1002,14 +1004,10 @@
 }
 
 proto_library("reflection_proto") {
-  sources = [
-    "src/proto/grpc/reflection/v1alpha/reflection.proto",
-  ]
+  sources = [ "src/proto/grpc/reflection/v1alpha/reflection.proto" ]
   generator_plugin_label = ":grpc_cpp_plugin"
   generator_plugin_suffix = ".grpc.pb"
-  deps = [
-    ":grpc++",
-  ]
+  deps = [ ":grpc++" ]
   proto_out_dir = "src/proto/grpc/reflection/v1alpha"
 }
 
@@ -1025,67 +1023,61 @@
     ":reflection_proto",
     "//third_party/protobuf:protobuf_full",
   ]
-  public_deps = [
-    ":grpc++",
-  ]
+  public_deps = [ ":grpc++" ]
 }
 
 # Only compile the plugin for the host architecture.
 if (current_toolchain == host_toolchain) {
-source_set("grpc_plugin_support") {
-  sources = [
-    "include/grpc++/impl/codegen/config_protobuf.h",
-    "src/compiler/config.h",
-    "src/compiler/cpp_generator.cc",
-    "src/compiler/cpp_generator.h",
-    "src/compiler/cpp_generator_helpers.h",
-    "src/compiler/csharp_generator.cc",
-    "src/compiler/csharp_generator.h",
-    "src/compiler/csharp_generator_helpers.h",
-    "src/compiler/generator_helpers.h",
-    "src/compiler/node_generator.cc",
-    "src/compiler/node_generator.h",
-    "src/compiler/node_generator_helpers.h",
-    "src/compiler/objective_c_generator.cc",
-    "src/compiler/objective_c_generator.h",
-    "src/compiler/objective_c_generator_helpers.h",
-    "src/compiler/php_generator.cc",
-    "src/compiler/php_generator.h",
-    "src/compiler/php_generator_helpers.h",
-    "src/compiler/protobuf_plugin.h",
-    "src/compiler/python_generator.cc",
-    "src/compiler/python_generator.h",
-    "src/compiler/python_generator_helpers.h",
-    "src/compiler/python_private_generator.h",
-    "src/compiler/ruby_generator.cc",
-    "src/compiler/ruby_generator.h",
-    "src/compiler/ruby_generator_helpers-inl.h",
-    "src/compiler/ruby_generator_map-inl.h",
-    "src/compiler/ruby_generator_string-inl.h",
-    "src/compiler/schema_interface.h",
-  ]
-  deps = [
-    "//third_party/protobuf:protoc_lib",
-  ]
+  source_set("grpc_plugin_support") {
+    sources = [
+      "include/grpc++/impl/codegen/config_protobuf.h",
+      "src/compiler/config.h",
+      "src/compiler/cpp_generator.cc",
+      "src/compiler/cpp_generator.h",
+      "src/compiler/cpp_generator_helpers.h",
+      "src/compiler/csharp_generator.cc",
+      "src/compiler/csharp_generator.h",
+      "src/compiler/csharp_generator_helpers.h",
+      "src/compiler/generator_helpers.h",
+      "src/compiler/node_generator.cc",
+      "src/compiler/node_generator.h",
+      "src/compiler/node_generator_helpers.h",
+      "src/compiler/objective_c_generator.cc",
+      "src/compiler/objective_c_generator.h",
+      "src/compiler/objective_c_generator_helpers.h",
+      "src/compiler/php_generator.cc",
+      "src/compiler/php_generator.h",
+      "src/compiler/php_generator_helpers.h",
+      "src/compiler/protobuf_plugin.h",
+      "src/compiler/python_generator.cc",
+      "src/compiler/python_generator.h",
+      "src/compiler/python_generator_helpers.h",
+      "src/compiler/python_private_generator.h",
+      "src/compiler/ruby_generator.cc",
+      "src/compiler/ruby_generator.h",
+      "src/compiler/ruby_generator_helpers-inl.h",
+      "src/compiler/ruby_generator_map-inl.h",
+      "src/compiler/ruby_generator_string-inl.h",
+      "src/compiler/schema_interface.h",
+    ]
+    deps = [ "//third_party/protobuf:protoc_lib" ]
 
-  configs += [ ":grpc_warnings" ]
-  public_configs = [ ":grpc_config" ]
-}
+    configs += [ ":grpc_warnings" ]
+    public_configs = [ ":grpc_config" ]
+  }
 }
 
 # Only compile the plugin for the host architecture.
 if (current_toolchain == host_toolchain) {
-executable("grpc_cpp_plugin") {
-  sources = [
-    "src/compiler/cpp_plugin.cc",
-  ]
-  deps = [
-    ":grpc_plugin_support",
-    "//third_party/protobuf:protoc_lib",
-  ]
+  executable("grpc_cpp_plugin") {
+    sources = [ "src/compiler/cpp_plugin.cc" ]
+    deps = [
+      ":grpc_plugin_support",
+      "//third_party/protobuf:protoc_lib",
+    ]
 
-  configs += [ ":grpc_warnings" ]
-  configs += [ "//third_party/protobuf:protobuf_config" ]
-  public_configs = [ ":grpc_config" ]
-}
+    configs += [ ":grpc_warnings" ]
+    configs += [ "//third_party/protobuf:protobuf_config" ]
+    public_configs = [ ":grpc_config" ]
+  }
 }