ipv6: skip tests on aix, fuchsia and hurd
Also marks test helper functions.
Change-Id: I1baf791b6d4199699db20834fa6e1a3bd0733cf0
Reviewed-on: https://go-review.googlesource.com/c/net/+/167340
Run-TryBot: Mikio Hara <mikioh.public.networking@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
diff --git a/ipv6/icmp_test.go b/ipv6/icmp_test.go
index bdde2fd..940a7aa 100644
--- a/ipv6/icmp_test.go
+++ b/ipv6/icmp_test.go
@@ -34,7 +34,7 @@
func TestICMPFilter(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
@@ -61,7 +61,7 @@
func TestSetICMPFilter(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
diff --git a/ipv6/mocktransponder_test.go b/ipv6/mocktransponder_test.go
index 6efe56c..1837c74 100644
--- a/ipv6/mocktransponder_test.go
+++ b/ipv6/mocktransponder_test.go
@@ -10,6 +10,7 @@
)
func connector(t *testing.T, network, addr string, done chan<- bool) {
+ t.Helper()
defer func() { done <- true }()
c, err := net.Dial(network, addr)
@@ -21,6 +22,7 @@
}
func acceptor(t *testing.T, ln net.Listener, done chan<- bool) {
+ t.Helper()
defer func() { done <- true }()
c, err := ln.Accept()
diff --git a/ipv6/multicast_test.go b/ipv6/multicast_test.go
index 50442c3..6ca6fd1 100644
--- a/ipv6/multicast_test.go
+++ b/ipv6/multicast_test.go
@@ -29,7 +29,7 @@
func TestPacketConnReadWriteMulticastUDP(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -129,7 +129,7 @@
func TestPacketConnReadWriteMulticastICMP(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
diff --git a/ipv6/multicastlistener_test.go b/ipv6/multicastlistener_test.go
index 1ee0549..91d2b1d 100644
--- a/ipv6/multicastlistener_test.go
+++ b/ipv6/multicastlistener_test.go
@@ -21,7 +21,7 @@
func TestUDPSinglePacketConnWithMultipleGroupListeners(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -61,7 +61,7 @@
func TestUDPMultiplePacketConnWithMultipleGroupListeners(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -116,7 +116,7 @@
func TestUDPPerInterfaceSinglePacketConnWithSingleGroupListener(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -172,7 +172,7 @@
func TestIPSinglePacketConnWithSingleGroupListener(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -216,7 +216,7 @@
switch runtime.GOOS {
case "darwin", "dragonfly", "openbsd": // platforms that return fe80::1%lo0: bind: can't assign requested address
t.Skipf("not supported on %s", runtime.GOOS)
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
diff --git a/ipv6/multicastsockopt_test.go b/ipv6/multicastsockopt_test.go
index 9906e87..2cb2da2 100644
--- a/ipv6/multicastsockopt_test.go
+++ b/ipv6/multicastsockopt_test.go
@@ -26,7 +26,7 @@
func TestPacketConnMulticastSocketOptions(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -73,6 +73,8 @@
}
func testMulticastSocketOptions(t *testing.T, c testIPv6MulticastConn, ifi *net.Interface, grp net.Addr) {
+ t.Helper()
+
const hoplim = 255
if err := c.SetMulticastHopLimit(hoplim); err != nil {
t.Error(err)
@@ -111,6 +113,8 @@
}
func testSourceSpecificMulticastSocketOptions(t *testing.T, c testIPv6MulticastConn, ifi *net.Interface, grp, src net.Addr) {
+ t.Helper()
+
// MCAST_JOIN_GROUP -> MCAST_BLOCK_SOURCE -> MCAST_UNBLOCK_SOURCE -> MCAST_LEAVE_GROUP
if err := c.JoinGroup(ifi, grp); err != nil {
t.Error(err)
diff --git a/ipv6/readwrite_test.go b/ipv6/readwrite_test.go
index e069cf8..18d5f9d 100644
--- a/ipv6/readwrite_test.go
+++ b/ipv6/readwrite_test.go
@@ -19,6 +19,11 @@
)
func BenchmarkReadWriteUnicast(b *testing.B) {
+ switch runtime.GOOS {
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
+ b.Skipf("not supported on %s", runtime.GOOS)
+ }
+
c, err := nettest.NewLocalPacketListener("udp6")
if err != nil {
b.Skipf("not supported on %s/%s: %v", runtime.GOOS, runtime.GOARCH, err)
@@ -66,7 +71,7 @@
func BenchmarkPacketConnReadWriteUnicast(b *testing.B) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
b.Skipf("not supported on %s", runtime.GOOS)
}
@@ -213,7 +218,7 @@
func TestPacketConnConcurrentReadWriteUnicastUDP(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -297,7 +302,7 @@
func TestPacketConnConcurrentReadWriteUnicast(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
@@ -350,6 +355,8 @@
}
func testPacketConnConcurrentReadWriteUnicast(t *testing.T, p *ipv6.PacketConn, data []byte, dst net.Addr, batch bool) {
+ t.Helper()
+
ifi := nettest.RoutedInterface("ip6", net.FlagUp|net.FlagLoopback)
cf := ipv6.FlagTrafficClass | ipv6.FlagHopLimit | ipv6.FlagSrc | ipv6.FlagDst | ipv6.FlagInterface | ipv6.FlagPathMTU
diff --git a/ipv6/sockopt_test.go b/ipv6/sockopt_test.go
index add045e..0ff911d 100644
--- a/ipv6/sockopt_test.go
+++ b/ipv6/sockopt_test.go
@@ -19,7 +19,7 @@
func TestConnInitiatorPathMTU(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -57,7 +57,7 @@
func TestConnResponderPathMTU(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -95,7 +95,7 @@
func TestPacketConnChecksum(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
diff --git a/ipv6/unicast_test.go b/ipv6/unicast_test.go
index 159bb39..25fb4eb 100644
--- a/ipv6/unicast_test.go
+++ b/ipv6/unicast_test.go
@@ -20,7 +20,7 @@
func TestPacketConnReadWriteUnicastUDP(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -78,7 +78,7 @@
func TestPacketConnReadWriteUnicastICMP(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
diff --git a/ipv6/unicastsockopt_test.go b/ipv6/unicastsockopt_test.go
index 69adefe..2f83373 100644
--- a/ipv6/unicastsockopt_test.go
+++ b/ipv6/unicastsockopt_test.go
@@ -16,7 +16,7 @@
func TestConnUnicastSocketOptions(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -61,7 +61,7 @@
func TestPacketConnUnicastSocketOptions(t *testing.T) {
switch runtime.GOOS {
- case "js", "nacl", "plan9", "windows":
+ case "aix", "fuchsia", "hurd", "js", "nacl", "plan9", "windows":
t.Skipf("not supported on %s", runtime.GOOS)
}
if !supportsIPv6 {
@@ -92,6 +92,8 @@
}
func testUnicastSocketOptions(t *testing.T, c testIPv6UnicastConn) {
+ t.Helper()
+
tclass := iana.DiffServCS0 | iana.NotECNTransport
if err := c.SetTrafficClass(tclass); err != nil {
switch runtime.GOOS {
