[go] Delete go_net_test

The go_net_test takes a dependency on Netstack2 so that it may test Go's
networking libraries on the Fuchsia Go Runtime. Because Netstack2 is
being deleted, we need to remove this dependency.

Rather than deleting go_net_test, I did consider moving the dependency
to Netstack3. However, I decided against that because:
* There are behavior differences in Netstack3 and uncover latent bugs in
  the Fuchsia Go Runtime (i.e. handling of unspecified addresses on dual
  stack TCP sockets). Switching to Netstack3 would require fixing these
  bugs.
* Following the deletion of Netstack2 will be the deletion of the
  Fuchsia Go Runtime. At which point these tests will be implicitly
  deleted.

Bug: 372466789, 571039994

Change-Id: Ic4b2ff3d8f81c5162a4315b27947f3c4592cdb0f
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/go/+/1870548
Reviewed-by: Bruno Dal Bo <brunodalbo@google.com>
Commit-Queue: Jeff Martin <martinjeffrey@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index f7a2c8f..46fe0e3 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -97,10 +97,6 @@
     gopackages = [ "os/exec" ]
   }
 
-  go_test("go_net_test") {
-    gopackages = [ "net" ]
-  }
-
   go_test("go_os_test") {
     gopackages = [ "os" ]
   }
@@ -127,12 +123,6 @@
     deps = [ ":go_exec_test" ]
   }
 
-  fuchsia_component("go-net-test") {
-    testonly = true
-    manifest = "meta/go_net_test.cml"
-    deps = [ ":go_net_test" ]
-  }
-
   fuchsia_component("go-os-test") {
     testonly = true
     manifest = "meta/go_os_test.cml"
@@ -185,7 +175,6 @@
   fuchsia_test_package("go-stdlib-tests") {
     test_components = [
       ":go-exec-test",
-      ":go-net-test",
       ":go-os-test",
       ":go-pprof-test",
       ":go-time-test",
@@ -193,8 +182,6 @@
       ":go-zxwait-test",
     ]
 
-    deps = [ "//src/connectivity/network/netstack:component" ]
-
     test_specs = {
       environments = [ emu_env ]
     }

meta/go_net_test.cml

diff --git a/meta/go_net_test.cml b/meta/go_net_test.cml
deleted file mode 100644
index 726d240..0000000
--- a/meta/go_net_test.cml
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright 2022 The Fuchsia Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-{
-    include: [
-        "//sdk/lib/inspect/offer.shard.cml",
-        "//src/sys/test_runners/gotests/default.shard.cml",
-        "//src/sys/test_runners/tmp_storage.shard.cml",
-    ],
-    program: {
-        binary: "test/go_net_test",
-        args: [
-            "--test.v",
-            "--test.timeout",
-            "2m",
-        ],
-    },
-    children: [
-        {
-            name: "netstack",
-            url: "#meta/netstack.cm",
-        },
-    ],
-    use: [
-        {
-            protocol: [
-                "fuchsia.net.interfaces.State",
-                "fuchsia.posix.socket.Provider",
-            ],
-            from: "#netstack",
-        },
-    ],
-    offer: [
-        {
-            protocol: [ "fuchsia.logger.LogSink" ],
-            from: "parent",
-            to: [ "#netstack" ],
-        },
-        {
-            dictionary: "diagnostics",
-            from: "parent",
-            to: [ "#netstack" ],
-        },
-        {
-            storage: "tmp",
-            from: "parent",
-            as: "cache",
-            to: "#netstack",
-        },
-    ],
-}