[fidl][go] Fixing InvertBits() implementation to match spec. [1/4]
InvertKnownBits(), added in I3389398b57cef03a578d3b381039cc75fe6427ff,
does not conform to the behavior specified in the bindings spec at
https://fuchsia.dev/fuchsia-src/reference/fidl/language/bindings-spec
zeroeing them out. This series of changes fixes that behavior, changing
the name of the method to InvertBits() in the process.
This first changelist disables the InvertKnownBits() test, enabling the
fidlgen_go API to be modified without breaking this downstream repo.
Next change in chain: I70765a89307001987501e3c9dfee109ff0ccc6a7
Test: fx test fidl_go_conformance go-fidl-tests go_extended_fidl_test go_unsafevalue_test
Change-Id: Ie64a9c917efaffaef3451a393458a53b57df5060
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/go/+/456768
Reviewed-by: Felix Zhu <fcz@google.com>
Commit-Queue: Alex Zaslavsky <azaslavsky@google.com>
diff --git a/src/syscall/zx/fidl/fidl_test/encoding_fuchsia_test.go b/src/syscall/zx/fidl/fidl_test/encoding_fuchsia_test.go
index 6b897f0..712a6a8 100644
--- a/src/syscall/zx/fidl/fidl_test/encoding_fuchsia_test.go
+++ b/src/syscall/zx/fidl/fidl_test/encoding_fuchsia_test.go
@@ -706,14 +706,14 @@
t.Errorf(
"Got wrong unknown bits: expected %b, was %b", 0b110100, unknownStrict.GetUnknownBits())
}
- if unknownStrict.InvertKnownBits() != 0b110110 {
- t.Errorf(
- "Got wrong InvertKnownBits: expected %b, got %b", 0b110110, unknownStrict.InvertKnownBits())
- }
- if unknownStrict != unknownStrict.InvertKnownBits().InvertKnownBits() {
- t.Errorf(
- "Got wrong double InvertKnownBits: expected %b, got %b", unknownStrict, unknownStrict.InvertKnownBits().InvertKnownBits())
- }
+ //if unknownStrict.InvertKnownBits() != 0b110110 {
+ // t.Errorf(
+ // "Got wrong InvertKnownBits: expected %b, got %b", 0b110110, unknownStrict.InvertKnownBits())
+ //}
+ //if unknownStrict != unknownStrict.InvertKnownBits().InvertKnownBits() {
+ // t.Errorf(
+ // "Got wrong double InvertKnownBits: expected %b, got %b", unknownStrict, unknownStrict.InvertKnownBits().InvertKnownBits())
+ //}
if !unknownStrict.HasBits(0b1) {
t.Errorf("Failed to match on known bits for HasBits")
}
@@ -752,14 +752,14 @@
t.Errorf(
"Got wrong unknown bits: expected %b, was %b", 0b110100, unknownFlexible.GetUnknownBits())
}
- if unknownFlexible.InvertKnownBits() != 0b110110 {
- t.Errorf(
- "Got wrong InvertKnownBits: expected %b, got %b", 0b110110, unknownFlexible.InvertKnownBits())
- }
- if unknownFlexible != unknownFlexible.InvertKnownBits().InvertKnownBits() {
- t.Errorf(
- "Got wrong double InvertKnownBits: expected %b, got %b", unknownFlexible, unknownFlexible.InvertKnownBits().InvertKnownBits())
- }
+ //if unknownFlexible.InvertKnownBits() != 0b110110 {
+ // t.Errorf(
+ // "Got wrong InvertKnownBits: expected %b, got %b", 0b110110, unknownFlexible.InvertKnownBits())
+ //}
+ //if unknownFlexible != unknownFlexible.InvertKnownBits().InvertKnownBits() {
+ // t.Errorf(
+ // "Got wrong double InvertKnownBits: expected %b, got %b", unknownFlexible, unknownFlexible.InvertKnownBits().InvertKnownBits())
+ //}
if !unknownFlexible.HasBits(0b1) {
t.Errorf("Failed to match on known bits for HasBits")
}
