commit 16e575a521a0ca0828d222accaa6b59c0074a85f
author Prashant Varanasi <github@prashantv.com> Mon Jul 18 11:25:57 2016 -0700
committer GitHub <noreply@github.com> Mon Jul 18 11:25:57 2016 -0700
tree c483abfc2580db320b8826889b6103b5ce576639
parent 3725100ae41f2a0dfbb85d3694143aa2c090657e
parent d938bba9065a590d68c7ae0767f31d1696dd35e7

Merge pull request #9 from uber-go/string_bug

Fix NewString disregarding the passed in string

string.go

diff --git a/string.go b/string.go
index 17eb42e..b3589ff 100644
--- a/string.go
+++ b/string.go
@@ -26,8 +26,12 @@
 type String struct{ atomic.Value }
 
 // NewString creates a String.
-func NewString(s string) *String {
-	return &String{}
+func NewString(str string) *String {
+	s := &String{}
+	if str != "" {
+		s.Store(str)
+	}
+	return s
 }
 
 // Load atomically loads the wrapped string.

string_test.go

diff --git a/string_test.go b/string_test.go
index 1c4ab8b..91b793e 100644
--- a/string_test.go
+++ b/string_test.go
@@ -39,5 +39,5 @@
 	require.Equal(t, "abc", atom.Load(), "Unexpected value after Store")
 
 	atom = NewString("bcd")
-	require.Equal(t, "", atom.Load(), "Expected Load to return initialized value")
+	require.Equal(t, "bcd", atom.Load(), "Expected Load to return initialized value")
 }