commit fbb9dc2cf1afbc1ca301c66bd3ec7e745dfed0e4
author John Kessenich <johnkslang@users.noreply.github.com> Wed Jun 24 02:53:45 2020 -0600
committer GitHub <noreply@github.com> Wed Jun 24 02:53:45 2020 -0600
tree 08cabb073d9ef19dca56dad7994211febd23c7b2
parent 839704450200e407490c538418f4d1a493b789ab
parent b90adef9284c0ea37cf4b24c87e4c4338eb4ec52

Merge pull request #2285 from proydakov/msvc-rtti-compilation-warning-fix

Fixed msvc 2019 nmake compiler warnings with RTTI.

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index cbf8378..bb5205e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -140,7 +140,12 @@
     endif()
 elseif(MSVC)
     if(NOT ENABLE_RTTI)
-        add_compile_options(/GR-) # Disable RTTI
+        string(FIND "${CMAKE_CXX_FLAGS}" "/GR" MSVC_HAS_GR)
+        if(MSVC_HAS_GR)
+            string(REGEX REPLACE /GR /GR- CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
+        else()
+            add_compile_options(/GR-) # Disable RTTI
+        endif()
     endif()
     if(ENABLE_EXCEPTIONS)
         add_compile_options(/EHsc) # Enable Exceptions