commit 9205e4205bff1878f21abddc5c526b159cdb87a4
author Luca Bacci <luca.bacci982@gmail.com> Mon Mar 01 11:35:58 2021 +0100
committer Philip Withnall <pwithnall@endlessos.org> Sun Mar 14 13:09:06 2021 +0000
tree 909ff5e742073f5fb8b70b240b97d1e7d5c60234
parent 01c5468e10707cbf78e6e83bbcf1ce9c866f2885

Use the right permissions for directory watching on Win32

Using FILE_GENERIC_READ | FILE_GENERIC_WRITE access rights for directory monitoring
might cause problems, as noted in https://gitlab.gnome.org/GNOME/gimp/-/issues/4594.

ReadDirectoryChanges only needs FILE_LIST_DIRECTORY, so use that.

Fixes: https://gitlab.gnome.org/GNOME/gimp/-/issues/4594

gio/win32/gwin32fsmonitorutils.c

diff --git a/gio/win32/gwin32fsmonitorutils.c b/gio/win32/gwin32fsmonitorutils.c
index e6b7d1d..b471246 100644
--- a/gio/win32/gwin32fsmonitorutils.c
+++ b/gio/win32/gwin32fsmonitorutils.c
@@ -345,7 +345,7 @@
     monitor->file_attribs = INVALID_FILE_ATTRIBUTES;
   monitor->pfni_prev = NULL;
   monitor->hDirectory = CreateFileW (wdirname_with_long_prefix != NULL ? wdirname_with_long_prefix : monitor->wfullpath_with_long_prefix,
-                                     FILE_GENERIC_READ | FILE_GENERIC_WRITE,
+                                     FILE_LIST_DIRECTORY,
                                      FILE_SHARE_DELETE | FILE_SHARE_READ | FILE_SHARE_WRITE,
                                      NULL,
                                      OPEN_EXISTING,