commit 49a877764d818ffeabe065bcc37ed22fbe6b6b51
author Simon McVittie <smcv@collabora.com> Fri Aug 03 13:42:38 2018 +0100
committer Simon McVittie <smcv@collabora.com> Fri Aug 03 13:42:38 2018 +0100
tree 64e1d2bcf318c009c938d7cb85ad312472de169c
parent 7cc5565e7c30bbfaa2ebc77a18ab9355137dfa5e

testing: Clarify why incomplete tests cause g_test_failed()


Signed-off-by: Simon McVittie <smcv@collabora.com>

glib/tests/testing.c

diff --git a/glib/tests/testing.c b/glib/tests/testing.c
index de95f26..0c2cf5d 100644
--- a/glib/tests/testing.c
+++ b/glib/tests/testing.c
@@ -648,7 +648,10 @@
   if (g_test_subprocess ())
     {
       g_test_incomplete ("not done");
-      g_assert (g_test_failed ());
+      /* This function really means "the test concluded with a non-successful
+       * status" rather than "the test failed": it is documented to return
+       * true for skipped and incomplete tests, not just for failures. */
+      g_assert_true (g_test_failed ());
       return;
     }
   g_test_trap_subprocess (NULL, 0, 0);