commit ab16fcc8dbdff5779d09c306741a2e508fb9bd67
author Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Sat Sep 29 22:59:00 2018 +0200
committer Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> Sat Sep 29 22:59:02 2018 +0200
tree 3579947809a2f5833d27831dc846d2cc96e6d95b
parent 754b7feaa144b22383457f9c0561adc9ebb24fd7

Wayland: Check for buffer creation failure

This prevents unusable decoration objects from being created, and
invalid cursors from being returned to the user.

src/wl_window.c

diff --git a/src/wl_window.c b/src/wl_window.c
index 93bb172..b23dc74 100644
--- a/src/wl_window.c
+++ b/src/wl_window.c
@@ -186,7 +186,7 @@
         _glfwInputError(GLFW_PLATFORM_ERROR,
                         "Wayland: Creating a buffer file for %d B failed: %m",
                         length);
-        return GLFW_FALSE;
+        return NULL;
     }
 
     data = mmap(NULL, length, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
@@ -195,7 +195,7 @@
         _glfwInputError(GLFW_PLATFORM_ERROR,
                         "Wayland: mmap failed: %m");
         close(fd);
-        return GLFW_FALSE;
+        return NULL;
     }
 
     pool = wl_shm_create_pool(_glfw.wl.shm, fd, length);
@@ -265,6 +265,8 @@
 
     if (!window->wl.decorations.buffer)
         window->wl.decorations.buffer = createShmBuffer(&image);
+    if (!window->wl.decorations.buffer)
+        return;
 
     createDecoration(&window->wl.decorations.top, window->wl.surface,
                      window->wl.decorations.buffer, opaque,
@@ -1308,6 +1310,9 @@
                               int xhot, int yhot)
 {
     cursor->wl.buffer = createShmBuffer(image);
+    if (!cursor->wl.buffer)
+        return GLFW_FALSE;
+
     cursor->wl.width = image->width;
     cursor->wl.height = image->height;
     cursor->wl.xhot = xhot;