commit 2e3745db08ca827f715752aa5109c6760b2e1bd0
author Stefan Berger <stefanb@linux.ibm.com> Tue Oct 05 16:22:25 2021 -0400
committer Stefan Berger <stefanb@us.ibm.com> Tue Oct 05 18:07:20 2021 -0400
tree d2a8bf31a09c5cf3ec9cc13e167b8b2ee1e3900f
parent b63a3e4b2e0b0b450485370b1c12c2b19068bcd9

swtpm_setup: Move gmalloc after block that may return NULL on failure

To avoid a memory leak, move the gmalloc after a block that may
return NULL on failure.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

src/swtpm_setup/swtpm_backend_file.c

diff --git a/src/swtpm_setup/swtpm_backend_file.c b/src/swtpm_setup/swtpm_backend_file.c
index c6b6b1e..a0d0f4d 100644
--- a/src/swtpm_setup/swtpm_backend_file.c
+++ b/src/swtpm_setup/swtpm_backend_file.c
@@ -32,9 +32,6 @@
         uri += 7;
     }
 
-    ret = g_malloc(sizeof(struct file_state));
-    ret->path = g_strdup(uri);
-
     stat_ret = stat(uri, &statbuf);
     if (stat_ret != 0) {
         noent = errno == ENOENT;
@@ -43,6 +40,9 @@
             return NULL;
         }
     }
+
+    ret = g_malloc(sizeof(struct file_state));
+    ret->path = g_strdup(uri);
     ret->is_blockdev = noent ? false : S_ISBLK(statbuf.st_mode);
 
     return (void*)ret;