commit c6b78f49f5515f56f675557263776bcd86000fb5
author Michal Privoznik <mprivozn@redhat.com> Fri Dec 02 15:22:04 2022 +0100
committer Stefan Berger <stefanb@us.ibm.com> Fri Dec 02 11:08:46 2022 -0500
tree 81b59d196fe633ecd8938bc31e953cb117511ceb
parent dcd1b575e67811570a27661b8ff53ef5316b9ccf

swtpm: Restore logging to stderr on log open failure

When opening a log file fails (--log file=/some/path) for
whatever reason the @logfd variable is left set to -1 (the retval
of open()). And due to how _logprintf() is written, the
subsequent attempt to log this failure (logprintf()) returns too
early not printing the useful error.

Therefore, restore the original (CONSOLE_LOGGING) value.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

src/swtpm/logging.c

diff --git a/src/swtpm/logging.c b/src/swtpm/logging.c
index 6e7d8f4..7314082 100644
--- a/src/swtpm/logging.c
+++ b/src/swtpm/logging.c
@@ -91,8 +91,10 @@
     }
 
     logfd = open(filename, flags, S_IRUSR|S_IWUSR);
-    if (logfd < 0)
+    if (logfd < 0) {
+        logfd = CONSOLE_LOGGING;
         return -1;
+    }
 
     log_prefix_clear();