Add test for image size for v1.12 and v1.13 clients against v1.13 daemon
This test checks to make sure both v1.12 and v1.13 client against v1.13 daemon get correct `Size` after the fix.
This test is related to 30027.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit d9451f1c8c8a584053ef06e0801df14e37d43cbd)
Signed-off-by: Victor Vieux <vieux@docker.com>
diff --git a/integration-cli/docker_api_images_test.go b/integration-cli/docker_api_images_test.go
index cde8a77..b7617ea 100644
--- a/integration-cli/docker_api_images_test.go
+++ b/integration-cli/docker_api_images_test.go
@@ -127,3 +127,39 @@
c.Assert(res.StatusCode, checker.Equals, http.StatusOK)
c.Assert(res.Header.Get("Content-Type"), checker.Equals, "application/json")
}
+
+// Test case for 30027: image size reported as -1 in v1.12 client against v1.13 daemon.
+// This test checks to make sure both v1.12 and v1.13 client against v1.13 daemon get correct `Size` after the fix.
+func (s *DockerSuite) TestAPIImagesSizeCompatibility(c *check.C) {
+ status, b, err := sockRequest("GET", "/images/json", nil)
+ c.Assert(err, checker.IsNil)
+ c.Assert(status, checker.Equals, http.StatusOK)
+ var images []types.ImageSummary
+ err = json.Unmarshal(b, &images)
+ c.Assert(err, checker.IsNil)
+ c.Assert(len(images), checker.Not(checker.Equals), 0)
+ for _, image := range images {
+ c.Assert(image.Size, checker.Not(checker.Equals), int64(-1))
+ }
+
+ type v124Image struct {
+ ID string `json:"Id"`
+ ParentID string `json:"ParentId"`
+ RepoTags []string
+ RepoDigests []string
+ Created int64
+ Size int64
+ VirtualSize int64
+ Labels map[string]string
+ }
+ status, b, err = sockRequest("GET", "/v1.24/images/json", nil)
+ c.Assert(err, checker.IsNil)
+ c.Assert(status, checker.Equals, http.StatusOK)
+ var v124Images []v124Image
+ err = json.Unmarshal(b, &v124Images)
+ c.Assert(err, checker.IsNil)
+ c.Assert(len(v124Images), checker.Not(checker.Equals), 0)
+ for _, image := range v124Images {
+ c.Assert(image.Size, checker.Not(checker.Equals), int64(-1))
+ }
+}
