chore: persistent objects are not in the cold path
diff --git a/src/include/lean/lean.h b/src/include/lean/lean.h index fdeea02..2cf48cc 100644 --- a/src/include/lean/lean.h +++ b/src/include/lean/lean.h
@@ -389,7 +389,7 @@ static inline void lean_inc_ref(lean_object * o) { if (LEAN_LIKELY(lean_is_st(o))) { o->m_rc++; - } else { + } else if (lean_is_mt(o)) { lean_inc_ref_cold(o); } } @@ -405,11 +405,13 @@ bool lean_dec_ref_core_cold(lean_object * o); static inline bool lean_dec_ref_core(lean_object * o) { - if (LEAN_LIKELY(o->m_rc > 1)) { + if (LEAN_LIKELY(o->m_rc >= 1)) { o->m_rc--; - return false; - } else { + return o->m_rc == 0; + } else if (lean_is_mt(o)) { return lean_dec_ref_core_cold(o); + } else { + return false; } }
diff --git a/src/runtime/object.cpp b/src/runtime/object.cpp index b09e84e..a776e95 100644 --- a/src/runtime/object.cpp +++ b/src/runtime/object.cpp
@@ -70,20 +70,14 @@ } extern "C" void lean_inc_ref_cold(lean_object * o) { - if (o->m_rc == 0) - return; atomic_fetch_sub_explicit(lean_get_rc_mt_addr(o), 1, memory_order_relaxed); } extern "C" void lean_inc_ref_n_cold(lean_object * o, unsigned n) { - if (o->m_rc == 0) - return; atomic_fetch_sub_explicit(lean_get_rc_mt_addr(o), n, memory_order_relaxed); } extern "C" bool lean_dec_ref_core_cold(lean_object * o) { - if (o->m_rc == 1) return true; - if (o->m_rc == 0) return false; return atomic_fetch_add_explicit(lean_get_rc_mt_addr(o), 1, memory_order_acq_rel) == -1; }