perf: cache `unfold_definition` in the kernel This PR ensures we cache the result of `unfold_definition` definition in the kernel type checker. We used to cache this information in a thread local storage, but it was deleted during the Lean 3 to Lean 4 transition.
diff --git a/src/kernel/type_checker.cpp b/src/kernel/type_checker.cpp index 2f681e4..76d69b9 100644 --- a/src/kernel/type_checker.cpp +++ b/src/kernel/type_checker.cpp
@@ -497,11 +497,22 @@ optional<expr> type_checker::unfold_definition_core(expr const & e) { if (is_constant(e)) { if (auto d = is_delta(e)) { - if (length(const_levels(e)) == d->get_num_lparams()) { + levels const & us = const_levels(e); + unsigned len = length(us); + if (len == d->get_num_lparams()) { if (m_diag) { m_diag->record_unfold(d->get_name()); } - return some_expr(instantiate_value_lparams(*d, const_levels(e))); + if (len > 0) { + auto it = m_st->m_unfold.find(e); + if (it != m_st->m_unfold.end()) + return some_expr(it->second); + expr result = instantiate_value_lparams(*d, us); + m_st->m_unfold.insert(mk_pair(e, result)); + return some_expr(result); + } else { + return some_expr(instantiate_value_lparams(*d, us)); + } } } }
diff --git a/src/kernel/type_checker.h b/src/kernel/type_checker.h index 78834d4..32fb89d 100644 --- a/src/kernel/type_checker.h +++ b/src/kernel/type_checker.h
@@ -33,6 +33,7 @@ expr_map<expr> m_whnf; equiv_manager m_eqv_manager; expr_pair_set m_failure; + expr_map<expr> m_unfold; friend type_checker; public: state(environment const & env);