commit 8c135e0b08e97d4c3e8d47127c9c9f1adb5f1153
author Jille Timmermans <jille@quis.cx> Fri Nov 06 07:29:29 2020 +0100
committer GitHub <noreply@github.com> Thu Nov 05 22:29:29 2020 -0800
tree 8ca58bf7adb499864b1367a48d07d0fb0269b0df
parent 472b7312287869df8a4da4304020f21ed1d7f90b

Ignore calls to Ack/Nack if the doneFunc isn't set (#3139)

This allows for simple testing.

I personally prefer https://github.com/googleapis/google-cloud-go/pull/2920, but I didn't win that.

Co-authored-by: Alex Hong <9397363+hongalex@users.noreply.github.com>

pubsub/message.go

diff --git a/pubsub/message.go b/pubsub/message.go
index 13dfbc6..00076ef 100644
--- a/pubsub/message.go
+++ b/pubsub/message.go
@@ -119,5 +119,7 @@
 		return
 	}
 	m.calledDone = true
-	m.doneFunc(m.ackID, ack, m.receiveTime)
+	if m.doneFunc != nil {
+		m.doneFunc(m.ackID, ack, m.receiveTime)
+	}
 }