Fix test names to not have unique identifier in them.
TESTED:
$ GCLOUD_TESTS_GOLANG_PROJECT_ID=dulcet-port-762 GCLOUD_TESTS_GOLANG_PROFILER_ZONE=us-west1-b go test -timeout=60m -v ./...
Change-Id: I8ea0c7f264f634356a0fe8c1e00360cca8fd71fb
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/44430
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Kalyana Chadalavada <kchadalavada@google.com>
diff --git a/profiler/integration_test.go b/profiler/integration_test.go
index 5c86f28..0678831 100644
--- a/profiler/integration_test.go
+++ b/profiler/integration_test.go
@@ -102,7 +102,7 @@
ErrorString string
MutexProfiling bool
}{
- Service: tc.name,
+ Service: tc.InstanceConfig.Name,
GoVersion: tc.goVersion,
Commit: commit,
ErrorString: errorString,
@@ -189,7 +189,7 @@
Name: fmt.Sprintf("profiler-test-gomaster-%s", runID),
MachineType: "n1-standard-1",
},
- name: fmt.Sprintf("profiler-test-gomaster-%s-gce", runID),
+ name: fmt.Sprintf("profiler-test-gomaster"),
wantProfileTypes: []string{"CPU", "HEAP", "THREADS", "CONTENTION", "HEAP_ALLOC"},
goVersion: "master",
mutexProfiling: true,
@@ -201,7 +201,7 @@
Name: fmt.Sprintf("profiler-test-go%s-%s", goVersionName, runID),
MachineType: "n1-standard-1",
},
- name: fmt.Sprintf("profiler-test-go%s-%s-gce", goVersionName, runID),
+ name: fmt.Sprintf("profiler-test-go%s", goVersionName),
wantProfileTypes: []string{"CPU", "HEAP", "THREADS", "CONTENTION", "HEAP_ALLOC"},
goVersion: goVersion,
mutexProfiling: true,
@@ -236,13 +236,13 @@
endTime := timeNow.Format(time.RFC3339)
startTime := timeNow.Add(-1 * time.Hour).Format(time.RFC3339)
for _, pType := range tc.wantProfileTypes {
- pr, err := tr.QueryProfilesWithZone(tc.ProjectID, tc.name, startTime, endTime, pType, tc.Zone)
+ pr, err := tr.QueryProfilesWithZone(tc.ProjectID, tc.InstanceConfig.Name, startTime, endTime, pType, tc.Zone)
if err != nil {
- t.Errorf("QueryProfilesWithZone(%s, %s, %s, %s, %s, %s) got error: %v", tc.ProjectID, tc.name, startTime, endTime, pType, tc.Zone, err)
+ t.Errorf("QueryProfilesWithZone(%s, %s, %s, %s, %s, %s) got error: %v", tc.ProjectID, tc.InstanceConfig.Name, startTime, endTime, pType, tc.Zone, err)
continue
}
if err := pr.HasFunction("busywork"); err != nil {
- t.Errorf("HasFunction(%s, %s, %s, %s, %s) got error: %v", tc.ProjectID, tc.name, startTime, endTime, pType, err)
+ t.Errorf("HasFunction(%s, %s, %s, %s, %s) got error: %v", tc.ProjectID, tc.InstanceConfig.Name, startTime, endTime, pType, err)
}
}
})
