commit 8be20cce6931433c8bc3124beea91922cd621423
author Abseil Team <absl-team@google.com> Mon Sep 18 03:17:14 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Sep 18 03:20:19 2023 -0700
tree 631637e850a39edab44c6ed85085f91704dc16ff
parent d1467f5813f4d363cfd11aba99c4e9fe47a85e99

Use the `empty()` method to check for emptiness instead of `length()`

PiperOrigin-RevId: 566247438
Change-Id: I8199ef53310a057abbe23f8f4295507b60d6b707

googletest/src/gtest-filepath.cc

diff --git a/googletest/src/gtest-filepath.cc b/googletest/src/gtest-filepath.cc
index 513e947..902d8c7 100644
--- a/googletest/src/gtest-filepath.cc
+++ b/googletest/src/gtest-filepath.cc
@@ -336,7 +336,7 @@
     return false;
   }
 
-  if (pathname_.length() == 0 || this->DirectoryExists()) {
+  if (pathname_.empty() || this->DirectoryExists()) {
     return true;
   }
 

googletest/src/gtest.cc

diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc
index 62dfef6..99b22ed 100644
--- a/googletest/src/gtest.cc
+++ b/googletest/src/gtest.cc
@@ -5400,7 +5400,7 @@
 int UnitTest::Run() {
 #ifdef GTEST_HAS_DEATH_TEST
   const bool in_death_test_child_process =
-      GTEST_FLAG_GET(internal_run_death_test).length() > 0;
+      !GTEST_FLAG_GET(internal_run_death_test).empty();
 
   // Google Test implements this protocol for catching that a test
   // program exits before returning control to Google Test: