Use ioutil.TempDir to create temporary directory (#123)
Rather than hand coding the temporary directory creation logic, use ioutil.TempDir with its own (seeded) random number generator independent of the math/rand default PRNG, so it doesn't suffer from trying a predictable and limited sequence of temporary directory names.
Fixes #45.
diff --git a/check.go b/check.go
index de714c2..bba8d8b 100644
--- a/check.go
+++ b/check.go
@@ -11,7 +11,7 @@
"errors"
"fmt"
"io"
- "math/rand"
+ "io/ioutil"
"os"
"path"
"path/filepath"
@@ -143,17 +143,11 @@
td.Lock()
defer td.Unlock()
if td.path == "" {
- var err error
- for i := 0; i != 100; i++ {
- path := fmt.Sprintf("%s%ccheck-%d", os.TempDir(), os.PathSeparator, rand.Int())
- if err = os.Mkdir(path, 0700); err == nil {
- td.path = path
- break
- }
- }
- if td.path == "" {
+ path, err := ioutil.TempDir("", "check-")
+ if err != nil {
panic("Couldn't create temporary directory: " + err.Error())
}
+ td.path = path
}
result := filepath.Join(td.path, strconv.Itoa(td.counter))
td.counter++
