commit f48204eee20ddb0a3b23c10d27e3c75fbcd3f7f3
author Kirill Chibisov <contact@kchibisov.com> Sat Jan 25 02:42:23 2020 +0300
committer Christian Duerr <contact@christianduerr.com> Sat Jan 25 00:42:23 2020 +0100
tree f4671121f45fa1084ce92f3de643e13cb442edc0
parent bdd28f4766a39ec679cc7422d5cff5c6e586ae43

Add font metric caching

CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 75c49bc..04323ba 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -37,6 +37,7 @@
 - Stack overflow when printing shader creation error
 - Underline position for bitmap fonts
 - Selection rotating outside of scrolling region
+- Throughput performance problems caused by excessive font metric queries
 
 ### Removed
 

alacritty/src/renderer/mod.rs

diff --git a/alacritty/src/renderer/mod.rs b/alacritty/src/renderer/mod.rs
index 2a1d872..a099b0d 100644
--- a/alacritty/src/renderer/mod.rs
+++ b/alacritty/src/renderer/mod.rs
@@ -341,9 +341,7 @@
     }
 
     pub fn font_metrics(&self) -> font::Metrics {
-        self.rasterizer
-            .metrics(self.font_key, self.font_size)
-            .expect("metrics load since font is loaded at glyph cache creation")
+        self.metrics
     }
 
     // Calculate font metrics without access to a glyph cache