commit 6db63012057a82b3528ede3f259684f3429731d5
author Rolf Eike Beer <eb@emlix.com> Tue Sep 19 11:55:53 2017 +0200
committer Rolf Eike Beer <eike@sf-mail.de> Tue Sep 19 17:37:29 2017 +0200
tree c24cc355885fe07258091cfb381f26d547334451
parent d44202ef05a1138bc71109def94c44aae18daf02

CTest: fix crash if source file for coverage cannot be found

The opened XML elements were not closed, so an assert was triggered when the
file was finally closed. If CMake is built with assertions disabled then an
invalid XML file will be produced.

Source/CTest/cmCTestCoverageHandler.cxx

diff --git a/Source/CTest/cmCTestCoverageHandler.cxx b/Source/CTest/cmCTestCoverageHandler.cxx
index 877cd24..28fae1c 100644
--- a/Source/CTest/cmCTestCoverageHandler.cxx
+++ b/Source/CTest/cmCTestCoverageHandler.cxx
@@ -570,6 +570,8 @@
       ostr << "Cannot open source file: " << fullPath;
       errorsWhileAccumulating.push_back(ostr.str());
       error++;
+      covLogXML.EndElement(); // Report
+      covLogXML.EndElement(); // File
       continue;
     }
     int untested = 0;