commit ffe07bf020bd683fa45a370345b77f967a3147b7
author Andrzej Kurek <andrzej.kurek@arm.com> Tue Jan 05 12:05:52 2021 +0100
committer GitHub <noreply@github.com> Tue Jan 05 12:05:52 2021 +0100
tree b7bfd0f6e74e725969efeac5217da6c6b909914b
parent 165564de07fb2426cd350eb6c7cdf5385a04f076
parent 17c3531b4bbc0d6bff37c834a3348c2c2499e378

Merge pull request #3977 from AndrzejKurek/fi-missing-volatile

FI variables missing 'volatile'

library/ssl_cli.c

diff --git a/library/ssl_cli.c b/library/ssl_cli.c
index 85473e6..22429e1 100644
--- a/library/ssl_cli.c
+++ b/library/ssl_cli.c
@@ -683,7 +683,7 @@
  */
 static int ssl_generate_random( mbedtls_ssl_context *ssl )
 {
-    int ret = MBEDTLS_ERR_PLATFORM_FAULT_DETECTED;
+    volatile int ret = MBEDTLS_ERR_PLATFORM_FAULT_DETECTED;
     unsigned char *p = ssl->handshake->randbytes;
 #if defined(MBEDTLS_HAVE_TIME)
     mbedtls_time_t t;
@@ -2956,7 +2956,7 @@
         mbedtls_pk_type_t pk_alg = MBEDTLS_PK_NONE;
         unsigned char *params = ssl->in_msg + mbedtls_ssl_hs_hdr_len( ssl );
         size_t params_len = p - params;
-        void *rs_ctx = NULL;
+        void * volatile rs_ctx = NULL;
 
         mbedtls_pk_context * peer_pk;
 

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 6415281..a25eecd 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -66,7 +66,7 @@
 {
     unsigned char * key;
     int ret = MBEDTLS_ERR_PLATFORM_FAULT_DETECTED;
-    int flow_ctrl = 0;
+    volatile int flow_ctrl = 0;
 #if defined(MBEDTLS_VALIDATE_SSL_KEYS_INTEGRITY)
     uint32_t hash;
 #endif
@@ -11769,7 +11769,7 @@
 static int ssl_write_real( mbedtls_ssl_context *ssl,
                            const unsigned char *buf, size_t len )
 {
-    int ret = mbedtls_ssl_get_max_out_record_payload( ssl );
+    volatile int ret = mbedtls_ssl_get_max_out_record_payload( ssl );
     const size_t max_len = (size_t) ret;
 
     if( ret < 0 )

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index 3b75bb5..18db3b2 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -2989,7 +2989,7 @@
     for( parent_crt = candidates; parent_crt != NULL;
          parent_crt = parent_crt->next )
     {
-        int parent_valid, parent_match, path_len_ok;
+        volatile int parent_valid, parent_match, path_len_ok;
 
 #if defined(MBEDTLS_ECDSA_C) && defined(MBEDTLS_ECP_RESTARTABLE)
 check_signature: