commit 5fff23b92abbf303c02f9e35f38a552372b2750a
author Paul Bakker <p.j.bakker@polarssl.org> Wed Mar 26 15:34:54 2014 +0100
committer Paul Bakker <p.j.bakker@polarssl.org> Wed Mar 26 15:34:54 2014 +0100
tree 8b1b3efe47560d70e0af573ed6165d22470d5a85
parent 4c284c9141c52ed9de90798cc39982be09b8b60c

x509_get_current_time() uses localtime_r() to prevent thread issues

ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 38f14dd..a6aa5b5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -59,6 +59,7 @@
    * ssl_handshake_init() was leaving dirty pointers in subcontexts if malloc
      of one of them failed
    * Fix typo in rsa_copy() that impacted PKCS#1 v2 contexts
+   * x509_get_current_time() uses localtime_r() to prevent thread issues
 
 = PolarSSL 1.3.4 released on 2014-01-27
 Features

library/x509.c

diff --git a/library/x509.c b/library/x509.c
index 9c3b0f4..57de545 100644
--- a/library/x509.c
+++ b/library/x509.c
@@ -636,18 +636,18 @@
     now->min = st.wMinute;
     now->sec = st.wSecond;
 #else
-    struct tm *lt;
+    struct tm lt;
     time_t tt;
 
     tt = time( NULL );
-    lt = localtime( &tt );
+    localtime_r( &tt, &lt );
 
-    now->year = lt->tm_year + 1900;
-    now->mon = lt->tm_mon + 1;
-    now->day = lt->tm_mday;
-    now->hour = lt->tm_hour;
-    now->min = lt->tm_min;
-    now->sec = lt->tm_sec;
+    now->year = lt.tm_year + 1900;
+    now->mon = lt.tm_mon + 1;
+    now->day = lt.tm_mday;
+    now->hour = lt.tm_hour;
+    now->min = lt.tm_min;
+    now->sec = lt.tm_sec;
 #endif
 }