chore(lint) (#4079)
* chore(lint)
I accidentally let 2 pieces of lint in with my generated code.
* fix(generate-code): I did not generate all the required code for tests.
diff --git a/.gitignore b/.gitignore
index 79c70d0..9dfabef 100755
--- a/.gitignore
+++ b/.gitignore
@@ -65,3 +65,4 @@
build/VS2010/FlatBuffers.opensdf
build/VS2010/ipch/**/*.ipch
*.so
+Testing/Temporary
diff --git a/src/idl_gen_js.cpp b/src/idl_gen_js.cpp
index 23fd52c..32c660c 100644
--- a/src/idl_gen_js.cpp
+++ b/src/idl_gen_js.cpp
@@ -557,13 +557,13 @@
"@returns {boolean}");
code += object_name + ".prototype.mutate_" + field.name + " = function(value) {\n";
- code += " var offset = this.bb.__offset(this.bb_pos, " + NumToString(field.value.offset) + ")\n\n";
+ code += " var offset = this.bb.__offset(this.bb_pos, " + NumToString(field.value.offset) + ");\n\n";
code += " if (offset === 0) {\n";
code += " return false;\n";
code += " }\n\n";
code += " this.bb.write" + MakeCamel(GenType(field.value.type)) + "(this.bb_pos + offset, value);\n";
code += " return true;\n";
- code += "}\n\n";
+ code += "};\n\n";
}
// Emit vector helpers
diff --git a/tests/monster_test.bfbs b/tests/monster_test.bfbs
index 66d3ee8..0369f89 100644
--- a/tests/monster_test.bfbs
+++ b/tests/monster_test.bfbs
Binary files differ
diff --git a/tests/monster_test_generated.js b/tests/monster_test_generated.js
index 6789ebb..dbb5ba6 100644
--- a/tests/monster_test_generated.js
+++ b/tests/monster_test_generated.js
@@ -132,7 +132,7 @@
* @returns {boolean}
*/
MyGame.Example.Test.prototype.mutate_a = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 0)
+ var offset = this.bb.__offset(this.bb_pos, 0);
if (offset === 0) {
return false;
@@ -140,7 +140,7 @@
this.bb.writeInt16(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -154,7 +154,7 @@
* @returns {boolean}
*/
MyGame.Example.Test.prototype.mutate_b = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 2)
+ var offset = this.bb.__offset(this.bb_pos, 2);
if (offset === 0) {
return false;
@@ -162,7 +162,7 @@
this.bb.writeInt8(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {flatbuffers.Builder} builder
@@ -226,7 +226,7 @@
* @returns {boolean}
*/
MyGame.Example.TestSimpleTableWithEnum.prototype.mutate_color = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 4)
+ var offset = this.bb.__offset(this.bb_pos, 4);
if (offset === 0) {
return false;
@@ -234,7 +234,7 @@
this.bb.writeInt8(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {flatbuffers.Builder} builder
@@ -298,7 +298,7 @@
* @returns {boolean}
*/
MyGame.Example.Vec3.prototype.mutate_x = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 0)
+ var offset = this.bb.__offset(this.bb_pos, 0);
if (offset === 0) {
return false;
@@ -306,7 +306,7 @@
this.bb.writeFloat32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -320,7 +320,7 @@
* @returns {boolean}
*/
MyGame.Example.Vec3.prototype.mutate_y = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 4)
+ var offset = this.bb.__offset(this.bb_pos, 4);
if (offset === 0) {
return false;
@@ -328,7 +328,7 @@
this.bb.writeFloat32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -342,7 +342,7 @@
* @returns {boolean}
*/
MyGame.Example.Vec3.prototype.mutate_z = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 8)
+ var offset = this.bb.__offset(this.bb_pos, 8);
if (offset === 0) {
return false;
@@ -350,7 +350,7 @@
this.bb.writeFloat32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -364,7 +364,7 @@
* @returns {boolean}
*/
MyGame.Example.Vec3.prototype.mutate_test1 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 16)
+ var offset = this.bb.__offset(this.bb_pos, 16);
if (offset === 0) {
return false;
@@ -372,7 +372,7 @@
this.bb.writeFloat64(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {MyGame.Example.Color}
@@ -386,7 +386,7 @@
* @returns {boolean}
*/
MyGame.Example.Vec3.prototype.mutate_test2 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 24)
+ var offset = this.bb.__offset(this.bb_pos, 24);
if (offset === 0) {
return false;
@@ -394,7 +394,7 @@
this.bb.writeInt8(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {MyGame.Example.Test=} obj
@@ -489,7 +489,7 @@
* @returns {boolean}
*/
MyGame.Example.Stat.prototype.mutate_val = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 6)
+ var offset = this.bb.__offset(this.bb_pos, 6);
if (offset === 0) {
return false;
@@ -497,7 +497,7 @@
this.bb.writeInt64(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -512,7 +512,7 @@
* @returns {boolean}
*/
MyGame.Example.Stat.prototype.mutate_count = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 8)
+ var offset = this.bb.__offset(this.bb_pos, 8);
if (offset === 0) {
return false;
@@ -520,7 +520,7 @@
this.bb.writeUint16(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {flatbuffers.Builder} builder
@@ -629,7 +629,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_mana = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 6)
+ var offset = this.bb.__offset(this.bb_pos, 6);
if (offset === 0) {
return false;
@@ -637,7 +637,7 @@
this.bb.writeInt16(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -652,7 +652,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_hp = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 8)
+ var offset = this.bb.__offset(this.bb_pos, 8);
if (offset === 0) {
return false;
@@ -660,7 +660,7 @@
this.bb.writeInt16(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {flatbuffers.Encoding=} optionalEncoding
@@ -709,7 +709,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_color = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 16)
+ var offset = this.bb.__offset(this.bb_pos, 16);
if (offset === 0) {
return false;
@@ -717,7 +717,7 @@
this.bb.writeInt8(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {MyGame.Example.Any}
@@ -732,7 +732,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_test_type = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 18)
+ var offset = this.bb.__offset(this.bb_pos, 18);
if (offset === 0) {
return false;
@@ -740,7 +740,7 @@
this.bb.writeUint8(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {flatbuffers.Table} obj
@@ -864,7 +864,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testbool = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 34)
+ var offset = this.bb.__offset(this.bb_pos, 34);
if (offset === 0) {
return false;
@@ -872,7 +872,7 @@
this.bb.writeInt8(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -887,7 +887,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashs32_fnv1 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 36)
+ var offset = this.bb.__offset(this.bb_pos, 36);
if (offset === 0) {
return false;
@@ -895,7 +895,7 @@
this.bb.writeInt32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -910,7 +910,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashu32_fnv1 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 38)
+ var offset = this.bb.__offset(this.bb_pos, 38);
if (offset === 0) {
return false;
@@ -918,7 +918,7 @@
this.bb.writeUint32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {flatbuffers.Long}
@@ -933,7 +933,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashs64_fnv1 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 40)
+ var offset = this.bb.__offset(this.bb_pos, 40);
if (offset === 0) {
return false;
@@ -941,7 +941,7 @@
this.bb.writeInt64(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {flatbuffers.Long}
@@ -956,7 +956,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashu64_fnv1 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 42)
+ var offset = this.bb.__offset(this.bb_pos, 42);
if (offset === 0) {
return false;
@@ -964,7 +964,7 @@
this.bb.writeUint64(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -979,7 +979,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashs32_fnv1a = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 44)
+ var offset = this.bb.__offset(this.bb_pos, 44);
if (offset === 0) {
return false;
@@ -987,7 +987,7 @@
this.bb.writeInt32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -1002,7 +1002,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashu32_fnv1a = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 46)
+ var offset = this.bb.__offset(this.bb_pos, 46);
if (offset === 0) {
return false;
@@ -1010,7 +1010,7 @@
this.bb.writeUint32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {flatbuffers.Long}
@@ -1025,7 +1025,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashs64_fnv1a = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 48)
+ var offset = this.bb.__offset(this.bb_pos, 48);
if (offset === 0) {
return false;
@@ -1033,7 +1033,7 @@
this.bb.writeInt64(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {flatbuffers.Long}
@@ -1048,7 +1048,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testhashu64_fnv1a = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 50)
+ var offset = this.bb.__offset(this.bb_pos, 50);
if (offset === 0) {
return false;
@@ -1056,7 +1056,7 @@
this.bb.writeUint64(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {number} index
@@ -1096,7 +1096,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testf = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 54)
+ var offset = this.bb.__offset(this.bb_pos, 54);
if (offset === 0) {
return false;
@@ -1104,7 +1104,7 @@
this.bb.writeFloat32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -1119,7 +1119,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testf2 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 56)
+ var offset = this.bb.__offset(this.bb_pos, 56);
if (offset === 0) {
return false;
@@ -1127,7 +1127,7 @@
this.bb.writeFloat32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -1142,7 +1142,7 @@
* @returns {boolean}
*/
MyGame.Example.Monster.prototype.mutate_testf3 = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 58)
+ var offset = this.bb.__offset(this.bb_pos, 58);
if (offset === 0) {
return false;
@@ -1150,7 +1150,7 @@
this.bb.writeFloat32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {number} index
diff --git a/tests/namespace_test/namespace_test1_generated.js b/tests/namespace_test/namespace_test1_generated.js
index a8fea9e..7551a18 100644
--- a/tests/namespace_test/namespace_test1_generated.js
+++ b/tests/namespace_test/namespace_test1_generated.js
@@ -69,7 +69,7 @@
* @returns {boolean}
*/
NamespaceA.NamespaceB.TableInNestedNS.prototype.mutate_foo = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 4)
+ var offset = this.bb.__offset(this.bb_pos, 4);
if (offset === 0) {
return false;
@@ -77,7 +77,7 @@
this.bb.writeInt32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {flatbuffers.Builder} builder
@@ -141,7 +141,7 @@
* @returns {boolean}
*/
NamespaceA.NamespaceB.StructInNestedNS.prototype.mutate_a = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 0)
+ var offset = this.bb.__offset(this.bb_pos, 0);
if (offset === 0) {
return false;
@@ -149,7 +149,7 @@
this.bb.writeInt32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @returns {number}
@@ -163,7 +163,7 @@
* @returns {boolean}
*/
NamespaceA.NamespaceB.StructInNestedNS.prototype.mutate_b = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 4)
+ var offset = this.bb.__offset(this.bb_pos, 4);
if (offset === 0) {
return false;
@@ -171,7 +171,7 @@
this.bb.writeInt32(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {flatbuffers.Builder} builder
diff --git a/tests/namespace_test/namespace_test2_generated.js b/tests/namespace_test/namespace_test2_generated.js
index 856bbff..c1c25ef 100644
--- a/tests/namespace_test/namespace_test2_generated.js
+++ b/tests/namespace_test/namespace_test2_generated.js
@@ -75,7 +75,7 @@
* @returns {boolean}
*/
NamespaceA.TableInFirstNS.prototype.mutate_foo_enum = function(value) {
- var offset = this.bb.__offset(this.bb_pos, 6)
+ var offset = this.bb.__offset(this.bb_pos, 6);
if (offset === 0) {
return false;
@@ -83,7 +83,7 @@
this.bb.writeInt8(this.bb_pos + offset, value);
return true;
-}
+};
/**
* @param {NamespaceA.NamespaceB.StructInNestedNS=} obj
