Google Git
Sign in
fuchsia / third_party / ffmpeg / refs/heads/upstream/release/3.3
commitaf8d5aab74c1fac2280e1a0b1e52c09b7e92e8b1[log] [tgz]
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>Sat Apr 20 00:03:15 2019 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>Fri Jul 03 14:13:50 2020 +0200
tree90a0ae2967b7b35222033c774b64d03a8bd82864
parenteb892918778164ff0b7a398954109e5fc5bf8872 [diff]
lavf/webm_chunk: Fix NULL dereference

The earlier version of the webm_chunk muxer had several bugs:

1. If the first packet of an audio stream didn't have a PTS of zero,
then no chunk will be started before a packet is delivered to the
underlying Matroska/WebM muxer, i.e. the AVFormatContext used to write
these packets had a NULL as AVIOContext for output. This is behind the
crash in ticket #5752.

2. If an error happens during writing a packet, the underlyimg
Matroska/WebM muxer context is freed. This leads to a use-after-free
coupled with a double-free in webm_chunk_write_trailer (which supposes
that the underlying AVFormatContext is still valid).

3. Even when no error occurs at all, webm_chunk_write_trailer is still
buggy: After the underlying Matroska/WebM muxer has written its trailer,
ending the chunk implicitly flushes it again which is illegal at this
point.

These bugs have been fixed.

Fixes #5752.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
(cherry picked from commit 8c6ee7626bcce7c270360f33b60dc7ef99939fc3)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
1 file changed
tree: 90a0ae2967b7b35222033c774b64d03a8bd82864
  1. compat/
  2. doc/
  3. libavcodec/
  4. libavdevice/
  5. libavfilter/
  6. libavformat/
  7. libavresample/
  8. libavutil/
  9. libpostproc/
  10. libswresample/
  11. libswscale/
  12. presets/
  13. tests/
  14. tools/
  15. .gitattributes
  16. .gitignore
  17. .travis.yml
  18. arch.mak
  19. Changelog
  20. cmdutils.c
  21. cmdutils.h
  22. cmdutils_common_opts.h
  23. cmdutils_opencl.c
  24. common.mak
  25. configure
  26. CONTRIBUTING.md
  27. COPYING.GPLv2
  28. COPYING.GPLv3
  29. COPYING.LGPLv2.1
  30. COPYING.LGPLv3
  31. CREDITS
  32. ffmpeg.c
  33. ffmpeg.h
  34. ffmpeg_cuvid.c
  35. ffmpeg_dxva2.c
  36. ffmpeg_filter.c
  37. ffmpeg_opt.c
  38. ffmpeg_qsv.c
  39. ffmpeg_vaapi.c
  40. ffmpeg_vdpau.c
  41. ffmpeg_videotoolbox.c
  42. ffplay.c
  43. ffprobe.c
  44. ffserver.c
  45. ffserver_config.c
  46. ffserver_config.h
  47. INSTALL.md
  48. library.mak
  49. LICENSE.md
  50. MAINTAINERS
  51. Makefile
  52. README.md
  53. RELEASE
  54. RELEASE_NOTES
  55. version.sh
README.md

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • ffserver is a multimedia streaming server for live broadcasts.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.