Google Git
Sign in
fuchsia / third_party / ffmpeg / eb892918778164ff0b7a398954109e5fc5bf8872
commiteb892918778164ff0b7a398954109e5fc5bf8872[log] [tgz]
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>Sun Sep 15 22:01:20 2019 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>Fri Jul 03 14:13:50 2020 +0200
treebc720ad8d5449b2189cecabb37943185ec45b635
parent25a0887c5a1d4e2cc4d84ddeabdfd7dc26a69786 [diff]
avcodec/ttaenc: Fix undefined shift

ttaenc contained (1 << unary) - 1 as an argument for a function
expecting an unsigned int. unary can be as big as 31 in this case.
The type of the shift and the whole expression is int, because 1 fits
into an integer, so that the behaviour is undefined if unary == 31
as the result of the shift can't be represented in an int §. Subtraction
by 1 (which makes the result of the whole expression representable in
an int) doesn't change that this is undefined (it usually leads to
signed integer overflow which is undefined, too).

The solution is simple: Make 1 unsigned to change the type of the
whole expression to unsigned int (as the function expects anyway).

Fixes ticket #8153.

§: This of course presupposes the common int range of -2^31..2^31-1

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 3ab488a5407f833ecc66e8fa4c537dc4852db720)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
1 file changed
tree: bc720ad8d5449b2189cecabb37943185ec45b635
  1. compat/
  2. doc/
  3. libavcodec/
  4. libavdevice/
  5. libavfilter/
  6. libavformat/
  7. libavresample/
  8. libavutil/
  9. libpostproc/
  10. libswresample/
  11. libswscale/
  12. presets/
  13. tests/
  14. tools/
  15. .gitattributes
  16. .gitignore
  17. .travis.yml
  18. arch.mak
  19. Changelog
  20. cmdutils.c
  21. cmdutils.h
  22. cmdutils_common_opts.h
  23. cmdutils_opencl.c
  24. common.mak
  25. configure
  26. CONTRIBUTING.md
  27. COPYING.GPLv2
  28. COPYING.GPLv3
  29. COPYING.LGPLv2.1
  30. COPYING.LGPLv3
  31. CREDITS
  32. ffmpeg.c
  33. ffmpeg.h
  34. ffmpeg_cuvid.c
  35. ffmpeg_dxva2.c
  36. ffmpeg_filter.c
  37. ffmpeg_opt.c
  38. ffmpeg_qsv.c
  39. ffmpeg_vaapi.c
  40. ffmpeg_vdpau.c
  41. ffmpeg_videotoolbox.c
  42. ffplay.c
  43. ffprobe.c
  44. ffserver.c
  45. ffserver_config.c
  46. ffserver_config.h
  47. INSTALL.md
  48. library.mak
  49. LICENSE.md
  50. MAINTAINERS
  51. Makefile
  52. README.md
  53. RELEASE
  54. RELEASE_NOTES
  55. version.sh
README.md

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • ffserver is a multimedia streaming server for live broadcasts.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.