commit 3059b7746aa996d81c2dfd075f7a23efb499d7d9
author Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Mon Apr 13 21:56:47 2020 +0200
committer Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Sun Apr 19 00:33:34 2020 +0200
tree bf994f451c5da226b3322fead7a1eb40f3b0c573
parent 2e92e1fb2706e6598104e5a5a8b1ecd02963e473

avformat/matroskadec: Remove redundant setting of chapter titles

Chapter titles are added to the chapter's metadata since 6cb6e159,
yet since 012867f0 (the predecessor of) avpriv_new_chapter() already
adds the title to the chapter's metadata. So setting it again in
matroskadec.c is redundant and expensive.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>

libavformat/matroskadec.c

diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index c699ce6..761d8b3 100644
--- a/libavformat/matroskadec.c
+++ b/libavformat/matroskadec.c
@@ -2933,10 +2933,6 @@
                                    (AVRational) { 1, 1000000000 },
                                    chapters[i].start, chapters[i].end,
                                    chapters[i].title);
-            if (chapters[i].chapter) {
-                av_dict_set(&chapters[i].chapter->metadata,
-                            "title", chapters[i].title, 0);
-            }
             max_start = chapters[i].start;
         }