[f2fs] Correct unlink operation

It removes marking an unlinked vnode as dirty
after deleting its entry. It causes that
unlinked vnodes are kept alive in the dirty vnode list
until checkpoint, wasting the resource.

This bug is detected in UnlinkTest.SpaceReturned.

Test: fx test f2fs-unittest f2fs-fs-tests f2fs-slow-fs-tests

Change-Id: I9530218c5d927fa872ba4f1fa4606c5954e70a4e
Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/f2fs/+/562021
Reviewed-by: Brett Wilson <brettw@google.com>
1 file changed
tree: 4f8391bc7d4703223d133dad33e25394a4e856d4
  1. patches/
  2. test/
  3. test_files/
  4. third_party/
  5. tools/
  6. AUTHORS
  7. bcache.cc
  8. bcache.h
  9. BUILD.gn
  10. checkpoint.cc
  11. CONTRIBUTING.md
  12. data.cc
  13. dir.cc
  14. dir.h
  15. dir_hash.cc
  16. f2fs.cc
  17. f2fs.h
  18. f2fs_internal.h
  19. f2fs_layout.h
  20. f2fs_lib.h
  21. f2fs_types.h
  22. file.cc
  23. file.h
  24. fsck.cc
  25. fsck.h
  26. gc.cc
  27. inline.cc
  28. LICENSE
  29. mkfs.cc
  30. mkfs.h
  31. mount.cc
  32. mount.h
  33. namei.cc
  34. namestring.h
  35. node.cc
  36. node.h
  37. PATENTS
  38. README.md
  39. recovery.cc
  40. segment.cc
  41. segment.h
  42. super.cc
  43. vnode.cc
  44. vnode.h
  45. vnode_cache.cc
  46. vnode_cache.h
README.md

What is F2FS?

F2FS is the most commonly used log-structured file system in Linux. It supports flash-friendly features such as adaptive logging, multi-head logging, fsync acceleration, and node address translation. For more information see: https://www.usenix.org/conference/fast15/technical-sessions/presentation/lee

Major Release

1st release (Apr-06-2021)

  • Features: mkfs, mount/umount, read, write, rmdir, mkdir, rename, fsync, lseek, link, unlink
  • Remarks
  • Fuchsia base code ; Thu Mar 11 08:53:24 2021 Prashanth Swaminathan,76a08ad1474 [speak] Migrate to new component templates
  • There is no cache. Every request is handled as a synchronous operation.
  • fsync() triggers checkpointing
  • lock granularity: file operation
  • LFS is used for block allocation by default, and IPU is forced when the number of free sections is below 50%.
  • no background/foreground gc
  • disable the roll-forward recovery
  • 6 active logs
  • disable the ext-identify feature
  • block allocation: LFS, IPU
  • fsck do nothing, but it returns true
  • no discard

2nd release (May-28-2021)

  • Features: truncate, ssr, fsync, recovery
  • Remarks
  • Fuchsia base code ; Thu May 20 07:25:45 2021 Yilong Li, 02c0dfff0fdb
  • support the roll-forward recovery and file level fsync()
  • block allocation: LFS, IPU, SSR
  • truncate

3rd release (June-25-2021)

  • Features: fsck, mount option, mkfs option
  • all fs-tests and large-fs-tests passed
  • Remarks
  • fsck (base: 7f35b548d4b)
  • support the ext-identify feature
  • support discard

4th release (July-30-2021)

  • Features: vnode cache, inline dentry
  • unit test coverage

5th release (August-27-2021)

  • Features: dentry cache
  • Landing
  • Linux compatibility test coverage

6th release (September-30-2021 ~)

  • Features: gc, node cache, pager support, mmap, wb, readahead, ... (as new fuchsia features coming)
  • stress test coverage
  • performance test

How to build

$ fx set core.x64 --with-base //bundles:tools --with-base //bundles:tests --with-base third_party/f2fs
(see third_party/f2fs/test_files/README.md for test)