commit c4709260f62f531eed83673104c7ecd7b6e665b7
author Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com> Thu Sep 06 11:55:03 2018 -0700
committer Ard Biesheuvel <ard.biesheuvel@linaro.org> Fri Sep 07 12:23:32 2018 +0200
tree 2db56fb374cae5c9bb68112e8d23bddb5820e731
parent c783da659915c27437047cad9b5d21b9804388c0

EmbeddedPkg/CoherentDmaLib: Add missing checks to DmaMap

UEFI Sct validates Dma mapping. For CoherentDmaLib it always failed
because there were no required checks present in DmaMap.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c

diff --git a/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c
index 8ca9e6a..eb88fa2 100644
--- a/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c
+++ b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c
@@ -58,6 +58,12 @@
   OUT    VOID                           **Mapping

   )

 {

+  if (HostAddress == NULL ||

+      NumberOfBytes == NULL ||

+      DeviceAddress == NULL ||

+      Mapping == NULL ) {

+    return EFI_INVALID_PARAMETER;

+  }

   *DeviceAddress = HostToDeviceAddress (HostAddress);

   *Mapping = NULL;

   return EFI_SUCCESS;