commit c7c387f1e28279bf02b9b6f6ac65225bfe59d7ce
author Justin Cohen <justincohen@google.com> Tue Feb 16 22:38:31 2021 -0500
committer Copybara-Service <copybara-worker@google.com> Mon Mar 08 11:03:16 2021 -0800
tree b4191dd3e8ff52b95a4547b865f0efedb7f8f835
parent d8ea84addd4766b8a891a50ba844978d03b04e44

ios: Expose EnableUploading in CrashpadClient.

This method should be called when an application is ready to start
uploading any pending reports.

Bug: crashpad: 31
Change-Id: Ic6584c40da2565c33e045e88382a09768304d3ae
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2698179
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
GitOrigin-RevId: b4bcc4df25ccdd82cf5a20e4b647e20a9d235cbc

client/crashpad_client.h

diff --git a/client/crashpad_client.h b/client/crashpad_client.h
index 594f307..cbe0551 100644
--- a/client/crashpad_client.h
+++ b/client/crashpad_client.h
@@ -472,10 +472,9 @@
   //!
   //! A handler must have already been installed before calling this method.
   //! This method should be called when an application is ready to start
-  //! processing previously created intermediate dumps and begin uploading.
-  //! Processing will block, so this should not be called on the main UI thread.
-  //! No intermediate dumps will be processed (and therefore no minidumps will
-  //! uploaded) until this method (or DumpWithoutCrash) is called.
+  //! processing previously created intermediate dumps. Processing will block,
+  //! so this should not be called on the main UI thread. No intermediate dumps
+  //! will be processed until this method is called.
   //!
   //! \param[in] annotations Process annotations to set in each crash report.
   //!     Useful when adding crash annotations detected on the next run after a
@@ -483,6 +482,12 @@
   void ProcessIntermediateDumps(
       const std::map<std::string, std::string>& annotations = {});
 
+  //! \brief Requests that the handler begin in-process uploading of any
+  //! pending reports.
+  //!
+  //! A handler must have already been installed before calling this method.
+  void EnableUploading();
+
   // TODO(justincohen): This method is purely for bringing up iOS interfaces.
   //! \brief Requests that the handler capture a dump even though there hasn't
   //!     been a crash.

client/crashpad_client_ios.cc

diff --git a/client/crashpad_client_ios.cc b/client/crashpad_client_ios.cc
index a40786b..588834c 100644
--- a/client/crashpad_client_ios.cc
+++ b/client/crashpad_client_ios.cc
@@ -234,6 +234,11 @@
 }
 
 // static
+void CrashpadClient::EnableUploading() {
+  // TODO(justincohen): Start the CrashReportUploadThread.
+}
+
+// static
 void CrashpadClient::DumpWithoutCrash(NativeCPUContext* context) {
   CrashHandler* crash_handler = CrashHandler::Get();
   DCHECK(crash_handler);