commit 865b08cb914e0493501e0b108f3e3f01ae7c11fb
author Joshua Peraza <jperaza@chromium.org> Tue Oct 27 09:14:08 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jan 19 07:17:01 2021 -0800
tree d47f68cd191b647c48468254cc073d7737472f0f
parent b6c8516813e20b97ec6176515941d769f76b281a

Be more tidy

Change-Id: I9f6eb74da91cca336fdb5ca4d5ded7604e2a4aee
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2502773
Reviewed-by: Mark Mentovai <mark@chromium.org>
GitOrigin-RevId: 68b10080d20937e9efe3306dd2a8a212cce02c4f

handler/linux/crash_report_exception_handler.cc

diff --git a/handler/linux/crash_report_exception_handler.cc b/handler/linux/crash_report_exception_handler.cc
index 557b171..9dc313c 100644
--- a/handler/linux/crash_report_exception_handler.cc
+++ b/handler/linux/crash_report_exception_handler.cc
@@ -43,10 +43,10 @@
 namespace crashpad {
 namespace {
 
-class Logger : public LogOutputStream::Delegate {
+class Logger final : public LogOutputStream::Delegate {
  public:
   Logger() = default;
-  ~Logger() = default;
+  ~Logger() override = default;
 
 #if defined(OS_ANDROID)
   int Log(const char* buf) override {

util/stream/log_output_stream.h

diff --git a/util/stream/log_output_stream.h b/util/stream/log_output_stream.h
index 5eff9a1..a1b6df3 100644
--- a/util/stream/log_output_stream.h
+++ b/util/stream/log_output_stream.h
@@ -50,7 +50,7 @@
     virtual size_t LineWidth() = 0;
   };
 
-  LogOutputStream(std::unique_ptr<Delegate> delegate);
+  explicit LogOutputStream(std::unique_ptr<Delegate> delegate);
   ~LogOutputStream() override;
 
   // OutputStreamInterface:

util/stream/log_output_stream_test.cc

diff --git a/util/stream/log_output_stream_test.cc b/util/stream/log_output_stream_test.cc
index f12aa76..9faf34b 100644
--- a/util/stream/log_output_stream_test.cc
+++ b/util/stream/log_output_stream_test.cc
@@ -31,11 +31,11 @@
 const char* kEndGuard = "-----END CRASHPAD MINIDUMP-----";
 const char* kAbortGuard = "-----ABORT CRASHPAD MINIDUMP-----";
 
-class LogOutputStreamTestDelegate : public LogOutputStream::Delegate {
+class LogOutputStreamTestDelegate final : public LogOutputStream::Delegate {
  public:
-  LogOutputStreamTestDelegate(std::string* logging_destination)
+  explicit LogOutputStreamTestDelegate(std::string* logging_destination)
       : logging_destination_(logging_destination) {}
-  ~LogOutputStreamTestDelegate() = default;
+  ~LogOutputStreamTestDelegate() override = default;
 
   int Log(const char* buf) override {
     size_t len = strnlen(buf, kLineBufferSize + 1);
@@ -53,7 +53,7 @@
 
 class LogOutputStreamTest : public testing::Test {
  public:
-  LogOutputStreamTest() : test_log_output_() {}
+  LogOutputStreamTest() {}
 
  protected:
   void SetUp() override {