commit 3ee255e78e1c0fb2b68a0bd073c6e68c01ee8c41
author Tamir Duberstein <tamird@google.com> Fri Sep 11 21:15:34 2020 +0000
committer Copybara-Service <copybara-worker@google.com> Tue Jan 19 07:15:20 2021 -0800
tree 6587e920f04228581fb0c25bf0e026c061ae01ea
parent cafcf59970d8f6cda5a0e3c2b40c66c3895c6b86

[fuchsia] Enable ConvertInvalidUTF8ToUTF16

All the referenced tracking issues are closed.

Bug: chromium:872892, chromium:889582, fuchsia:5355
Change-Id: I06ab2d370d7e3784c430c0f47ea7702fed7ff902
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2405369
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
GitOrigin-RevId: 76c6de22e1c2063ac5541a1cb9c99e02a52df09d

minidump/minidump_string_writer_test.cc

diff --git a/minidump/minidump_string_writer_test.cc b/minidump/minidump_string_writer_test.cc
index ddb8c48..489df5b 100644
--- a/minidump/minidump_string_writer_test.cc
+++ b/minidump/minidump_string_writer_test.cc
@@ -102,12 +102,6 @@
   }
 }
 
-// Related tracking issues:
-// https://fuchsia.atlassian.net/browse/DX-487
-// https://bugs.chromium.org/p/chromium/issues/detail?id=872892
-// https://bugs.chromium.org/p/chromium/issues/detail?id=889582
-// TODO: Re-enable test once LUCI supports invalid UTF8 characters in test logs.
-#if !defined(CRASHPAD_IS_IN_FUCHSIA)
 TEST(MinidumpStringWriter, ConvertInvalidUTF8ToUTF16) {
   StringFile string_file;
 
@@ -147,7 +141,6 @@
     EXPECT_NE(output_string.find(0xfffd), base::string16::npos);
   }
 }
-#endif  // !defined(CRASHPAD_IS_IN_FUCHSIA)
 
 TEST(MinidumpStringWriter, MinidumpUTF8StringWriter) {
   StringFile string_file;