commit 3b782a14cc537111e5cdb90e3369fa1e7579a2c0
author Ken Rockot <rockot@google.com> Fri May 14 13:13:23 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Fri May 14 13:45:53 2021 -0700
tree f8f71d08d48b0ed7c78a41e55fbed39b2ab1e06f
parent 551b9388af9174d2279860d26e5326a2356bffa6

Fix ScopedFD usage in unit test

Fixes a minor detail in the CrashReportDatabaseTest.CleanBrokenDatabase
test wherein a ScopedFD is explicitly closed before being released.
Despite being technically safe in this instance, an impending upstream
Chromium change to track and enforce ScopedFD ownership will catch this
as a potential bug and intentionally crash the test.

Change-Id: I6b8da6ce55698aa50d176693a203136000cdba66
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2898048
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
GitOrigin-RevId: a6494f9df645b360b13b76fa2df32e38f0c6f8ac

client/crash_report_database_test.cc

diff --git a/client/crash_report_database_test.cc b/client/crash_report_database_test.cc
index 6796de6..3c6a057 100644
--- a/client/crash_report_database_test.cc
+++ b/client/crash_report_database_test.cc
@@ -828,8 +828,7 @@
 
   ASSERT_TRUE(LoggingWriteFile(
       handle.get(), &expired_timestamp, sizeof(expired_timestamp)));
-  ASSERT_TRUE(LoggingCloseFile(handle.get()));
-  ignore_result(handle.release());
+  ASSERT_TRUE(LoggingCloseFile(handle.release()));
 
   EXPECT_EQ(db()->CleanDatabase(0), 1);