commit 0f35f5c3f2bf2ce518e8f23e34436e73e97c9438
author Nico Weber <thakis@chromium.org> Mon Mar 23 14:59:21 2020 -0400
committer Copybara-Service <copybara-worker@google.com> Tue Jan 19 06:48:48 2021 -0800
tree 6fea1f8ce6b502de6341a8296e0f1da30ba04208
parent cf84ad07c6df6fd67ad1b57af8d4c3bd1cc97636

Prepare crashpad mig stuff for -Wunreachable-code in chromium_code.

Bug: chromium:346399
Change-Id: Ibab7aa36f7c66ede0b107fa7a60670747146e7f7
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2116252
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
GitOrigin-RevId: 296501351816448182af26c5f51c41e1a0ff7bea

util/BUILD.gn

diff --git a/util/BUILD.gn b/util/BUILD.gn
index aa89026..bd0d242 100644
--- a/util/BUILD.gn
+++ b/util/BUILD.gn
@@ -75,6 +75,17 @@
       rebase_path("../compat/mac", root_build_dir),
     ]
   }
+
+  source_set("mig_output") {
+    deps = [ ":mig" ]
+    sources = get_target_outputs(":mig")
+    if (crashpad_is_in_chromium) {
+      # mig output contains unreachable code, which irks -Wunreachable-code.
+      configs -= [ "//build/config/compiler:chromium_code" ]
+      configs += [ "//build/config/compiler:no_chromium_code" ]
+    }
+    public_configs = [ "..:crashpad_config" ]
+  }
 }
 
 static_library("util") {
@@ -281,7 +292,6 @@
       "process/process_memory_mac.h",
       "synchronization/semaphore_mac.cc",
     ]
-    sources += get_target_outputs(":mig")
   }
 
   deps = []
@@ -483,7 +493,7 @@
       "IOKit.framework",
     ]
     deps += [
-      ":mig",
+      ":mig_output",
       "../third_party/apple_cf:apple_cf",
     ]
     include_dirs += [ "$root_build_dir/gen" ]