Make WriteDepFile escape spaces and special characters
This commit makes deptools.WriteDepFile() escape spaces and the
following set of special characters in the dependencies it
writes to files used as Ninja depfiles: \, #, *, [, |. Without this
change, dependencies with paths including any of the above may not
function as intended.
Change-Id: I3560a34de930932422200985fb479515a21d9508
diff --git a/deptools/depfile.go b/deptools/depfile.go
index cc114f6..bfcf2ce 100644
--- a/deptools/depfile.go
+++ b/deptools/depfile.go
@@ -20,6 +20,16 @@
"strings"
)
+var (
+ pathEscaper = strings.NewReplacer(
+ `\`, `\\`,
+ ` `, `\ `,
+ `#`, `\#`,
+ `*`, `\*`,
+ `[`, `\[`,
+ `|`, `\|`)
+)
+
// WriteDepFile creates a new gcc-style depfile and populates it with content
// indicating that target depends on deps.
func WriteDepFile(filename, target string, deps []string) error {
@@ -29,8 +39,14 @@
}
defer f.Close()
+ var escapedDeps []string
+
+ for _, dep := range deps {
+ escapedDeps = append(escapedDeps, pathEscaper.Replace(dep))
+ }
+
_, err = fmt.Fprintf(f, "%s: \\\n %s\n", target,
- strings.Join(deps, " \\\n "))
+ strings.Join(escapedDeps, " \\\n "))
if err != nil {
return err
}
