commit 0e78738a2541f81fa4103ead4c4bacfc19bd39bf
author staffantj <8728287+staffantj@users.noreply.github.com> Mon Jan 10 10:44:42 2022 -0500
committer GitHub <noreply@github.com> Mon Jan 10 15:44:42 2022 +0000
tree 78403c2675f7318583d31c07f38c184b6b37e942
parent 6dfe7afbc31ee1cc7ea9d2688758dc70a61bd285

Destructor not returning is expected in some cases (#1316)

* Address MSVC C4722 warning in tests

Some test paths deliberately exit, and it appears that the appropriate declspec
does not stop the compiler generating the C4722 warning as one might expect.

Per https://github.com/google/benchmark/issues/826#issuecomment-851995549
this commit ignores the warning for the affected call site.

* Fix up Formatting

* Fix up formatting issue on pragmas

* Fix up formatting issue on pragmas take 2

Co-authored-by: Staffan Tjernstrom <staffantj@users.noreply.github.com>

src/check.h

diff --git a/src/check.h b/src/check.h
index 0efd13f..90c7bbf 100644
--- a/src/check.h
+++ b/src/check.h
@@ -36,10 +36,17 @@
 
   LogType& GetLog() { return log_; }
 
+#if defined(COMPILER_MSVC)
+#pragma warning(push)
+#pragma warning(disable : 4722)
+#endif
   BENCHMARK_NORETURN ~CheckHandler() BENCHMARK_NOEXCEPT_OP(false) {
     log_ << std::endl;
     CallAbortHandler();
   }
+#if defined(COMPILER_MSVC)
+#pragma warning(pop)
+#endif
 
   CheckHandler& operator=(const CheckHandler&) = delete;
   CheckHandler(const CheckHandler&) = delete;