commit 95428817d6ec576a25e124bc7a0e89b248701ee3
author Treehugger Robot <treehugger-gerrit@google.com> Thu Jun 09 19:07:27 2016 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Jun 09 19:07:27 2016 +0000
tree cc1a3e791b502fd3c12e1cb1aa47d059524c168a
parent 8c60f2dcfe0107b407400010bcf76b72d5ec076d
parent 397de1494f6b622292f474f7e174ddefb2220040

Merge "ueventd: only relabel devices if there's a delta"

init/devices.cpp

diff --git a/init/devices.cpp b/init/devices.cpp
index 1410e3b..32fec52 100644
--- a/init/devices.cpp
+++ b/init/devices.cpp
@@ -257,11 +257,25 @@
     /* If the node already exists update its SELinux label to handle cases when
      * it was created with the wrong context during coldboot procedure. */
     if (mknod(path, mode, dev) && (errno == EEXIST)) {
-        if (lsetfilecon(path, secontext)) {
+
+        char* fcon = nullptr;
+        int rc = lgetfilecon(path, &fcon);
+        if (rc < 0) {
+            ERROR("Cannot get SELinux label on '%s' device (%s)\n",
+                    path, strerror(errno));
+            goto out;
+        }
+
+        bool different = strcmp(fcon, secontext) != 0;
+        freecon(fcon);
+
+        if (different && lsetfilecon(path, secontext)) {
             ERROR("Cannot set '%s' SELinux label on '%s' device (%s)\n",
                     secontext, path, strerror(errno));
         }
     }
+
+out:
     chown(path, uid, -1);
     setegid(AID_ROOT);