commit dae0195380686dbec450e298f4acf47b5f9576e6
author Lorenzo Colitti <lorenzo@google.com> Wed Apr 10 12:01:34 2019 +0900
committer Lorenzo Colitti <lorenzo@google.com> Wed Apr 10 12:11:42 2019 +0900
tree e79afe5df5de5355fb3d3ceb73a9e10baa533254
parent 3458bb6ce1d3e73e15075b5962a3662af0af5e04

Make the SocketListener control pipe O_CLOEXEC.

Children of processes that use SocketListener should not be able
to stop the SocketListener.

Test: builds, boots
Test: atest libsysutils_tests
Test: atest --test-mapping system/netd
Change-Id: I64898d9966f62004468b8e8a43b59be4a81a8cc4

libsysutils/src/SocketListener.cpp

diff --git a/libsysutils/src/SocketListener.cpp b/libsysutils/src/SocketListener.cpp
index ded5adb..9780606 100644
--- a/libsysutils/src/SocketListener.cpp
+++ b/libsysutils/src/SocketListener.cpp
@@ -95,7 +95,7 @@
     } else if (!mListen)
         mClients[mSock] = new SocketClient(mSock, false, mUseCmdNum);
 
-    if (pipe(mCtrlPipe)) {
+    if (pipe2(mCtrlPipe, O_CLOEXEC)) {
         SLOGE("pipe failed (%s)", strerror(errno));
         return -1;
     }