commit 422367b97f5e3abcf8e4552fddf12f35e18e66f9
author Steven Moreland <smoreland@google.com> Tue Mar 06 14:57:46 2018 -0800
committer Steven Moreland <smoreland@google.com> Wed Mar 07 19:00:15 2018 +0000
tree be3d40861e8531eb26cda38fbe1c0c8de3341883
parent 1d5b102671ba3cf5da51026328a75012d56f3b98

init: use FQName parse

FQName::FQName(string) could leave the FQName in an
invalid state, and so this constructor is being removed
and the mValid member is being removed.

Bug: 73774955
Test: boots + interface_start control messages received by init
Change-Id: I58d4a089c0a0f1c2cc5129c5e87321e7f6663b72

init/service.cpp

diff --git a/init/service.cpp b/init/service.cpp
index 8130e73..964393f 100644
--- a/init/service.cpp
+++ b/init/service.cpp
@@ -446,8 +446,8 @@
     const std::string& interface_name = args[1];
     const std::string& instance_name = args[2];
 
-    const FQName fq_name = FQName(interface_name);
-    if (!fq_name.isValid()) {
+    FQName fq_name;
+    if (!FQName::parse(interface_name, &fq_name)) {
         return Error() << "Invalid fully-qualified name for interface '" << interface_name << "'";
     }