commit fb368f762fa17d1456f153bc3d67d4de4c452472
author Martijn Coenen <maco@google.com> Thu Aug 10 15:03:18 2017 +0200
committer Martijn Coenen <maco@google.com> Fri Aug 11 10:59:04 2017 +0200
tree 437076bcc48ccd79fb6a860ff5916a9e72fb5cf8
parent 45b07b49ba37ef4843087a2e6c35c8776d1a3c25

Fix BINDER_LIB_TEST_NOP_CALL_BACK.

To write in the request Parcel instead of the reply Parcel.

Also fixed reading the callback return value to use
readInt32(&...), so we correctly set the status if
there was no data in the Parcel.

Test: binderLibTest passes
Change-Id: I1c5b075b6f1f6d19c40e7bf9589a94809ce414ff

libs/binder/tests/binderLibTest.cpp

diff --git a/libs/binder/tests/binderLibTest.cpp b/libs/binder/tests/binderLibTest.cpp
index 218b37e..1425940 100644
--- a/libs/binder/tests/binderLibTest.cpp
+++ b/libs/binder/tests/binderLibTest.cpp
@@ -331,10 +331,14 @@
             (void)reply;
             (void)flags;
             switch(code) {
-            case BINDER_LIB_TEST_CALL_BACK:
-                m_result = data.readInt32();
+            case BINDER_LIB_TEST_CALL_BACK: {
+                status_t status = data.readInt32(&m_result);
+                if (status != NO_ERROR) {
+                    m_result = status;
+                }
                 triggerEvent();
                 return NO_ERROR;
+            }
             case BINDER_LIB_TEST_CALL_BACK_VERIFY_BUF: {
                 sp<IBinder> server;
                 int ret;
@@ -1044,7 +1048,7 @@
                 if (binder == NULL) {
                     return BAD_VALUE;
                 }
-                reply2.writeInt32(NO_ERROR);
+                data2.writeInt32(NO_ERROR);
                 binder->transact(BINDER_LIB_TEST_CALL_BACK, data2, &reply2);
                 return NO_ERROR;
             }