commit 3f31b6319f88ba81470c21711dacfb0b8bf11bee
author Narayan Kamath <narayan@google.com> Thu Feb 22 19:42:36 2018 +0000
committer Narayan Kamath <narayan@google.com> Thu Feb 22 19:49:04 2018 +0000
tree 03acdd7bc998e7e3bc7664c4ea8d4dbc07a7de12
parent 019681c7cf29ba7b97085ed7453671ddceaecc65

Fix broken time comparison.

This change fixes a broken check that excludes all recent tombstones
and ANRs and only preserves old ones. Luckily, limit_by_mtime is only
true for flat (non-zipped) bug reports so we haven't seen this too
often in practice.

Test: manual
Bug: 73759506
Change-Id: Ic7856a4a1f5af3b1d5c5becb7bc83d2def4a71ea

cmds/dumpstate/dumpstate.cpp

diff --git a/cmds/dumpstate/dumpstate.cpp b/cmds/dumpstate/dumpstate.cpp
index a641dbb..8258c45 100644
--- a/cmds/dumpstate/dumpstate.cpp
+++ b/cmds/dumpstate/dumpstate.cpp
@@ -180,7 +180,7 @@
             continue;
         }
 
-        if (limit_by_mtime && st.st_mtime >= thirty_minutes_ago) {
+        if (limit_by_mtime && st.st_mtime < thirty_minutes_ago) {
             MYLOGI("Excluding stale dump file: %s\n", abs_path.c_str());
             continue;
         }