commit 4931894f0318c2f32e71a497d55b0e547197f925
author Ivan Lozano <ivanlozano@google.com> Wed Dec 06 10:43:57 2017 -0800
committer Ivan Lozano <ivanlozano@google.com> Wed Dec 20 08:21:30 2017 -0800
tree cb1b50f3e03eda64fa466ee05a7a8f973d3915bd
parent 240201e27b1722009907a31983825668f2416ec2

Fix overflow sanitizer in EffectVisualizer.

This makes an implicit conversion to a signed integer explicit before
the unsigned integer overflow happens. This was causing runtime errors
on integer sanitized builds.

 runtime error: unsigned integer overflow: 1664 - 4096 cannot be
 represented in type 'unsigned int'

Bug: 30969751
Test: Compiles.
Change-Id: I1d4b5ab024e94c19ff448110064340125cd01e01
Merged-In: I1d4b5ab024e94c19ff448110064340125cd01e01

media/libeffects/visualizer/EffectVisualizer.cpp

diff --git a/media/libeffects/visualizer/EffectVisualizer.cpp b/media/libeffects/visualizer/EffectVisualizer.cpp
index 0e82339..c33f9f5 100644
--- a/media/libeffects/visualizer/EffectVisualizer.cpp
+++ b/media/libeffects/visualizer/EffectVisualizer.cpp
@@ -594,7 +594,7 @@
                     deltaSmpl = CAPTURE_BUF_SIZE;
                 }
 
-                int32_t capturePoint = pContext->mCaptureIdx - deltaSmpl;
+                int32_t capturePoint = (int32_t)pContext->mCaptureIdx - deltaSmpl;
                 // a negative capturePoint means we wrap the buffer.
                 if (capturePoint < 0) {
                     uint32_t size = -capturePoint;