commit 200072af0850f0b31f4aac8481ccf7d98acfd9ee
author Zach Jang <zachjang@google.com> Tue Oct 27 01:24:55 2015 +0000
committer The Android Automerger <android-build@google.com> Tue Oct 27 15:22:09 2015 -0700
tree c5aaca0e05e7877424d5da0717bbd883a13793bc
parent 1e959f5fa2718e32ee8bdd037e6e0a51cf64a158

Revert "AudioPolicyService: fix race in AudioCommandThread"

This reverts commit 74ce88ff0f24a8c08fdab3a1140212183089c2b5.

Change-Id: I39114c8cdd3021951ba93716aaa0c1c03e68538d

services/audiopolicy/service/AudioPolicyService.cpp

diff --git a/services/audiopolicy/service/AudioPolicyService.cpp b/services/audiopolicy/service/AudioPolicyService.cpp
index c77cc45..eefff3d 100644
--- a/services/audiopolicy/service/AudioPolicyService.cpp
+++ b/services/audiopolicy/service/AudioPolicyService.cpp
@@ -577,28 +577,22 @@
                     }
                 }
                 waitTime = INT64_MAX;
-                // release mLock before releasing strong reference on the service as
-                // AudioPolicyService destructor calls AudioCommandThread::exit() which
-                // acquires mLock.
-                mLock.unlock();
-                svc.clear();
-                mLock.lock();
             } else {
                 waitTime = mAudioCommands[0]->mTime - curTime;
                 break;
             }
         }
-
-        // release delayed commands wake lock if the queue is empty
-        if (mAudioCommands.isEmpty()) {
+        // release mLock before releasing strong reference on the service as
+        // AudioPolicyService destructor calls AudioCommandThread::exit() which acquires mLock.
+        mLock.unlock();
+        svc.clear();
+        mLock.lock();
+        if (!exitPending() && (mAudioCommands.isEmpty() || waitTime != INT64_MAX)) {
+            // release delayed commands wake lock
             release_wake_lock(mName.string());
-        }
-
-        // At this stage we have either an empty command queue or the first command in the queue
-        // has a finite delay. So unless we are exiting it is safe to wait.
-        if (!exitPending()) {
             ALOGV("AudioCommandThread() going to sleep");
             mWaitWorkCV.waitRelative(mLock, waitTime);
+            ALOGV("AudioCommandThread() waking up");
         }
     }
     // release delayed commands wake lock before quitting
@@ -1009,8 +1003,6 @@
         requestExit();
         mWaitWorkCV.signal();
     }
-    // Note that we can call it from the thread loop if all other references have been released
-    // but it will safely return WOULD_BLOCK in this case
     requestExitAndWait();
 }