commit 4ee43b8ce34fc03e30f9f0f2d0e74ada2f8b3f34
author Treehugger Robot <treehugger-gerrit@google.com> Thu Dec 06 02:10:36 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Dec 06 02:10:36 2018 +0000
tree 16cf0c93d6b3dcfa4abf6c9268b6057ca3ab57e0
parent 9ba3b6613b4e5130fa01a11d984c6b5f0eb3af05
parent 3580f25308c3636f50220b786456b813be478a66

Merge "at_auth_unlock.py: Fix exception when using Python2 w/ non-unlock cred in directory"

libavb/avb_slot_verify.c

diff --git a/libavb/avb_slot_verify.c b/libavb/avb_slot_verify.c
index 72f5091..75b26d6 100644
--- a/libavb/avb_slot_verify.c
+++ b/libavb/avb_slot_verify.c
@@ -1442,10 +1442,13 @@
       if (has_system_partition(ops, ab_suffix)) {
         slot_data->cmdline =
             avb_strdup("root=PARTUUID=$(ANDROID_SYSTEM_PARTUUID)");
-        if (slot_data->cmdline == NULL) {
-          ret = AVB_SLOT_VERIFY_RESULT_ERROR_OOM;
-          goto fail;
-        }
+      } else {
+        // The |cmdline| field should be a NUL-terminated string.
+        slot_data->cmdline = avb_strdup("");
+      }
+      if (slot_data->cmdline == NULL) {
+        ret = AVB_SLOT_VERIFY_RESULT_ERROR_OOM;
+        goto fail;
       }
     } else {
       /* If requested, manage dm-verity mode... */
@@ -1480,7 +1483,7 @@
     }
 
     /* Substitute $(ANDROID_SYSTEM_PARTUUID) and friends. */
-    if (slot_data->cmdline != NULL) {
+    if (slot_data->cmdline != NULL && avb_strlen(slot_data->cmdline) != 0) {
       char* new_cmdline;
       new_cmdline = avb_sub_cmdline(ops,
                                     slot_data->cmdline,

test/avb_slot_verify_unittest.cc

diff --git a/test/avb_slot_verify_unittest.cc b/test/avb_slot_verify_unittest.cc
index 829e9a6..e03c37e 100644
--- a/test/avb_slot_verify_unittest.cc
+++ b/test/avb_slot_verify_unittest.cc
@@ -2142,7 +2142,7 @@
     EXPECT_EQ("root=PARTUUID=1234-fake-guid-for:system_a",
               std::string(slot_data->cmdline));
   } else {
-    EXPECT_EQ(nullptr, slot_data->cmdline);
+    EXPECT_EQ("", std::string(slot_data->cmdline));
   }
 
   // Also make sure that it actually loads the boot and dtbo partitions.